Reimplemented Aabb.rs in godot-core/src/builtin #280
Conversation
|
Thanks! A lot of suggestions from #276 are unaddressed in this pull request. Can we close that one first, with only doc aliases (no AABB features)? Otherwise we have a lot of overlap and repeated reviews. 🙂 |
Cankyre
force-pushed
the
core/reimplementation
branch
2 times, most recently
from
63a2c9b to
6548821
Compare
|
I think it should be good now? |
|
bors try |
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-280 |
tryBuild failed: |
|
@Cankyre this fails with the double builds. To verify that it passes, you can run the tests locally using |
|
Should pass the tests now! 👍 |
| /// Returns the volume of the AABB. | ||
| /// | ||
| /// _Godot equivalent: `AABB.get_volume()`_ | ||
| #[inline] | ||
| pub fn volume(&self) -> real { | ||
| self.assert_nonnegative(); | ||
| self.size.x * self.size.y * self.size.z | ||
| } |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
bors try |
tryMerge conflict. |
Cankyre
force-pushed
the
core/reimplementation
branch
from
2c3ded5 to
91629d6
Compare
|
@Bromeon seems good to go! |
Cankyre
force-pushed
the
core/reimplementation
branch
from
91629d6 to
23b3c2f
Compare
|
Thanks a lot! bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Added all methods and tests to Aabb.rs in godot-builtin