Add CallError, try_* varcalls and improve error diagnostics
#634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously rendered as Variant(ty=..., val=...). Now dispatches on the value and uses its `Debug` impl instead. This should still be unambiguous, e.g. StringName/NodePath have &"..." and ^"..." syntax to differentiate them from GString.
Bromeon
added
feature
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauls the entire call diagnostic system, changing panics to
Results internally and significantly improving user-facing error messages.Fallible varcall methods such as
Object::call()orNode::call_group()now receive an additionaltry_*overload which returnsResult<T, CallError>instead of panicking.CallErroris a new type that embodies function call errors, and allows to inspect the affected class/method, as well as the chain of calls.Incidentally improves
ConvertErrormessages, makesVariant'sDebugimpl more concise, and disables excessive panic printing in integration tests.There is some work left for later PRs:
try_overloads, but at least use the same code path).Variant::call()Callable::call().try_*invocations.CallErroracross Godot function boundaries (maybe 1 per thread instead of ever-growing).