Skip to content

PR #5/5 Astolfo feature/example-update #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

PR #5/5 Astolfo feature/example-update #69

merged 1 commit into from
Feb 1, 2023

Conversation

RealAstolfo
Copy link

Changed the example to fit the newer rust api

Co-Authored-By: Thomas ten Cate [email protected]

@Bromeon Bromeon added feature Adds functionality to the library c: core Core components labels Jan 16, 2023
Bromeon
Bromeon reviewed Jan 21, 2023
View reviewed changes
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one possibly relevant change left, do you want to include it or close this PR?

@Bromeon Bromeon force-pushed the astolfo-feature/example-update branch from 8a6b640 to 6370183 Compare February 1, 2023 19:17
@Bromeon
Copy link
Member

Bromeon commented Feb 1, 2023

Rebased onto master, this leaves only the velocity changes in the diff.
It's a good way to demonstrate the vector constants though. As such,

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 1, 2023

Build succeeded:

@bors bors bot merged commit 3182bd4 into godot-rust:master Feb 1, 2023
@RealAstolfo RealAstolfo deleted the astolfo-feature/example-update branch February 5, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bromeon Bromeon Bromeon left review comments

Assignees
No one assigned
Labels
c: core Core components feature Adds functionality to the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RealAstolfo @Bromeon