ClassBuilder, ToVariant/FromVariant and Export explanations. #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To resolve Issue godot-rust#38 I have added some entries in `rust-bindings/properties.md` In addition, I added a section that can better explain the `ToVariant`, `FromVariant` and `Export` traits as these are going to end up being really common issues for folks that work heavily with the Godot Editor
|
I've gone over and fixed up this PR. @Bromeon If you have any feedback or nitpicks, please let me know otherwise I'll go ahead and squash/merge it. |
Bromeon
requested changes
Nov 14, 2021
|
I added the fixes as requested. Let me know if there's anything else that you'd like to see changed :) |
|
Should be good, thanks! 🙂 |
|
Thank you for the reviews! I'll go ahead and squash/merge the changes :) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve Issue #38 I have added some entries in
rust-bindings/properties.mdIn addition, I added a section that can better explain the
ToVariant,FromVariantandExporttraits as these are going to end up being really common issues for folks that work heavily with the Godot Editor.I am opening this as a draft for some initial feedback on the ideas not necessarily the typos, if I have any major misunderstandings in my explanations please let me know so I can update it. Please don't worry about typos for the time being as I plan to go over and edit this again.