-
Notifications
You must be signed in to change notification settings - Fork 211
List of methods that can be exported to Godot #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Bromeon I'll go ahead and work on this one. I think it's a natural extension to the work from documenting the For now, I'll assume that we are primarily interested in virtual methods like Please feel free to let me know if you have any other points you'd like me to mention. I'll try to get a PR in by early next week. |
Yes, the focus are I agree that the signature, a one-liner explaining what it does and a link to the Godot docs would be good.
The question is where we want to add these docs? |
@Bromeon I'll proceed by using that sample as the template for this change. With regards to where it should be added, I was thinking that the The reason is that I believe the biggest risk to not documenting is that a user may not be aware of which function names are reserved for Godot to call via notifications. For example: If a user thinks "oh, I need a private method that processes some data occasionally, I'll just call it That was just my line of thinking though. |
…on from Node and Control. closes godot-rust#672
…on from Node and Control. closes godot-rust#672
…on from Node and Control. closes godot-rust#672
…o the Godot Docs in the #[export] trait documentation. Also fixed up as per the requests in PR godot-rust#781 closes godot-rust#672
…o the Godot Docs in the #[export] trait documentation. Also fixed up as per the requests in PR godot-rust#781 closes godot-rust#672
…o the Godot Docs in the #[export] trait documentation. Also fixed up as per the requests in PR godot-rust#781 closes godot-rust#672
…o the Godot Docs in the #[export] trait documentation. Also fixed up as per the requests in PR godot-rust#781 Fixed the doc test failures. closes godot-rust#672
781: Added Godot exportable methods along with the expected signature r=jacobsky a=jacobsky Added a list of the Godot Virtual methods from Node and Control to the #[export] trait documentation. closes #672 Co-authored-by: Jacobsky <[email protected]>
…o the Godot Docs in the #[export] trait documentation. Also fixed up as per the requests in PR godot-rust#781 Fixed the doc test failures. closes godot-rust#672
…o the Godot Docs in the #[export] trait documentation. Also fixed up as per the requests in PR godot-rust#781 Fixed the doc test failures. closes godot-rust#672
Add a list of methods to the documentation that can be exported to Godot (ex: _input(), _ready(),...) and most importantly the parameter/argument types.
There is the Godot documentation but this is not for the Rust structs. https://docs.godotengine.org/en/stable/classes/class_node.html#method-descriptions
Although not hard now. I was first struggling to find the right types that the parameters should have in Rust. Maybe add something like this to the doc page here:
https://docs.rs/gdnative/0.9.1/gdnative/attr.methods.html
Or links to Godot docs. As searching in rust docs (https://docs.rs/gdnative/0.9.1/gdnative/index.html?search=_input) does not turn of anything (useful).
Created this issue after posting it on Discord.
The text was updated successfully, but these errors were encountered: