Skip to content

Unify string parameters across all builders #996

@chitoyuu

Description

@chitoyuu
Contributor

Created during survey of commented code (#377).

As of Rust 1.63.0, the turbofish syntax can now be used along with impl Trait: https://blog.rust-lang.org/2022/08/11/Rust-1.63.0.html#turbofish-for-generics-in-functions-with-impl-trait

As such, we now have more freedom to use types like impl Into<GodotString> or impl Into<Cow<'a, str>> where we need to take string arguments (for names) along with explicit type arguments in builders.

This may still constitute a breaking change, if a technical one.

Activity

added
c: exportComponent: export (mod export, derive)
breaking-changeIssues and PRs that are breaking to fix/merge.
quality-of-lifeNo new functionality, but improves ergonomics/internals
on Dec 7, 2022
added this to the v0.12.0 milestone on Jan 4, 2023
linked a pull request that will close this issue on Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking-changeIssues and PRs that are breaking to fix/merge.c: exportComponent: export (mod export, derive)quality-of-lifeNo new functionality, but improves ergonomics/internals

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @chitoyuu

      Issue actions

        Unify string parameters across all builders · Issue #996 · godot-rust/gdnative