Implement owner argument inference #633
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the use of `_` as types of arguments named `owner` or `_owner` within `#[methods]` blocks. Such placeholders will be automatically replaced with `TRef<'_, Self::Base, Shared>` for convenience. This should make typing function signatures less tedious, and give new users a sufficiently sane default owner argument type that just works in common use cases: calling methods and passing as arguments. This should also help with the rather frequent confusion new users face when they try to write something that don't extend `Node`. The downside is that it makes more things implicit, although it can be argued that `owner` in godot-rust is close enough to `self` to make this acceptable. Documentation is added to the `#[methods]` attribute macro to explain the exact behavior for advanced users.
ghost
added
feature
|
Closing after gathering feedback. The consensus is that this is too much "magic", and it breaks IDEs too much, which is undesirable. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the use of
_as types of arguments namedowneror_ownerwithin#[methods]blocks. Such placeholders will be automatically replaced withTRef<'_, Self::Base, Shared>for convenience.This should make typing function signatures less tedious, and give new users a sufficiently sane default owner argument type that just works in common use cases: calling methods and passing as arguments. This should also help with the rather frequent confusion new users face when they try to write something that don't extend
Node.The downside is that it makes more things implicit, although it can be argued that
ownerin godot-rust is close enough toselfto make this acceptable. Documentation is added to the#[methods]attribute macro to explain the exact behavior for advanced users.Draft status: The change itself is simple enough and not really expected to impact #609 a lot, but some opinions on whether this is a good feature would be really helpful.