Fixed Logo: off-by-one pixel strip error #801
Conversation
Bromeon
added
the
c: tools
|
Thank you for your contribution! Could you add the following line (marked bold below, but don't add it in bold) to godot-ferris-license.txt?
This should also be future-proof for a while. |
assets/godot-ferris-license.txt
Outdated
| version 3.0 (CC-BY 3.0) <https://creativecommons.org/licenses/by/3.0/legalcode>. | ||
|
|
||
| See https://github.com/godotengine/godot/. | ||
| See https://github.com/godotengine/godot/. |
There was a problem hiding this comment.
What changed here? Whitespace?
Unfortunately the online viewer doesn't show it...
The clip path for group "g20" which holds the upper border of the claws was aligned exactly to the inside of the outer border. Due to rounding error, an orange strip was sometimes erroneously drawn where the two borders meet for each claw. Expanding the bounds of the clip path is sufficient to alleviate the issue entirely. appended to reflect minor change Update godot-ferris-license.txt
|
@Bromeon My editor automatically added a newline at the end of the file, which Github seemingly hides. I have fixed it and squashed into the original commit. After some floundering I think it's finally ready. 😄 |
|
Thank you very much! |
|
Build succeeded: |
The clip path for group "g20" which holds the upper border of the claws was aligned exactly to the inside of the outer border. Due to rounding error, a single-pixel width orange strip was sometimes erroneously drawn where the two borders meet for each claw. Expanding the bounds of the clip path is sufficient to alleviate the issue entirely.
Left: Old
Right: Fixed
https://imgur.com/a/K3dERDL