Skip to content

Conversation

TokisanGames
Copy link
Contributor

  • Moves mono downloads from dockers to build.sh
  • Retains dnf cache
  • Adds progress to git downloads
  • Replaces git apply with more reliable patch

Should address relevant notes in reference #38

Note: dnf clean all became dnf clean packages to save dnf cache and only remove the packages. However the default dnf configuration doesn't save the packages. keepcache=false is the default and must be set true in /etc/dnf/dnf.con in order to save packages. So dnf clean is removed entirely everywhere.


ENV MONO64_PREFIX=/root/dependencies/mono
rm -rf /root/${mono_version}

Copy link
Contributor Author

@TokisanGames TokisanGames Mar 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MONO64_PREFIX deprecated and ignored by scons


ENV MONO32_PREFIX=/root/dependencies/mono-32
ENV MONO64_PREFIX=/root/dependencies/mono-64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MONO32/64_PREFIX deprecated and ignored by scons

[Yy]* ) break;;
[Nn]* ) exit 1;;
* ) echo "Please answer yes or no.";;
esac
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now ./build.sh master mono-6.6.0.160 2019-08 bef1e6335812d32f8eab648c0228fc624b9f8357 will make (and check for) a folder called files/mono-2019-08-bef1e6. Also it will say (exists) if found, so you know it won't be downloaded again.

patch -p1 < ${files_root}/patches/mono-unity-Clear-TLS-instead-of-aborting.patch
popd
fi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-j 6 made a huge difference in total download time. Less timeout and waiting because it was downloading other modules while one was timing out.

This was referenced Mar 19, 2020
@akien-mga akien-mga merged commit 6a799cb into godotengine:master Apr 6, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants