Replace std::list with List #1842
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::list was being used in in one place for method args in class_db.hpp. This replaces it with Godot's List.
This works fine but after looking at the code I'm pretty sure this shouldn't even be using a List at all. It's only used in MethodDefinition's args member but internally Godot uses a
Vector<StringName>
for this but godot-cpp is using aList<StringName>
. godot-cpp's D_METHOD works different than the internal Godot one though so maybe this is intentional? Either way I don't want to make that change until #1841 gets merged as they will conflict.