Skip to content

x/benchmarks/sweet: change dir when building #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Lslightly
Copy link

@Lslightly Lslightly commented Mar 18, 2025

change dir to cfg.GoRoot to avoid installing cmd/compile cmd/link in pkg/mod specified by benchmarks' go.mod.

Fixes golang/go#72920

change dir to cfg.GoRoot to avoid installing cmd/compile cmd/link in
pkg/mod specified by benchmarks' go.mod
@gopherbot
Copy link
Contributor

This PR (HEAD: e8f846c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/benchmarks/+/658795.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/658795.
After addressing review feedback, remember to publish your drafts!

@Lslightly Lslightly changed the title x/benchmarks/sweet: change dir when building cmd/compile and cmd/link x/benchmarks/sweet: change dir when building Mar 18, 2025
@Lslightly Lslightly closed this Mar 19, 2025
@Lslightly
Copy link
Author

For go version >= version written in go.mod, currently 1.23.0, no problems will occur. For go < 1.23.0, the go.mod will download go whose version >= 1.23.0 automatically as https://go.dev/doc/toolchain says.

For example, when using the go command bundled with Go 1.21.3 in a main module that says go 1.21.9, the go command finds and runs Go 1.21.9 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/benchmarks/sweet: go-build failed when install cmd/compile and cmd/link
2 participants