Skip to content

cmd/gopherbot, cmd/gopherstats: update the use of github api #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

h8liu
Copy link
Contributor

@h8liu h8liu commented Aug 10, 2018

@h8liu h8liu changed the title update the use of github api cmd/gopherbot, cmd/gopherstats: update the use of github api Aug 10, 2018
@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 13437:

Patch Set 2:

Not sure about the mod file - probably - but you'll also want to update the Dockerfile for cmd/gopherbot, which pulls down a specific commit. You should be able to test it by running "cd cmd/gopherbot && make docker-staging".


Please don’t reply on this GitHub thread. Visit golang.org/cl/129075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 3:

Dmitri can own this review & helping you update the rest of the parts (the "make update-deps" for the relevant directories with Dockerfiles using this)


Please don’t reply on this GitHub thread. Visit golang.org/cl/129075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 6005:

Patch Set 3:

(1 comment)

Thanks for the PR, Lonnie.

About go.mod (/cc Bryan), I think it's fine to leave it for later. Its use is still experimental, and we can update it as necessary as part of golang/go#26872. It's not the canonical source that's used when deploying gopherbot at this time.

Let's update cmd/gopherbot/Dockerfile, as Kevin mentioned. You should be able to:

cd cmd/gopherbot
make update-deps

You should be able to test it by running "cd cmd/gopherbot && make docker-staging".

I think you meant "cd cmd/gopherbot && make docker-image".

(If you don't have docker handy, I can test it on my side.)


Please don’t reply on this GitHub thread. Visit golang.org/cl/129075.
After addressing review feedback, remember to publish your drafts!

@h8liu
Copy link
Contributor Author

h8liu commented Aug 16, 2018

I ran the commands you suggested. make docker-image says okay.

As a side effect, it also updates other repos.

@gopherbot
Copy link
Contributor

Message from Gerrit User 27645:

Patch Set 4:

I ran the commands you suggested. make docker-image says okay.

As a side effect, it also updates other repos.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 12446:

Uploaded patch set 5: Commit message was updated.


Please don’t reply on this GitHub thread. Visit golang.org/cl/129075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 6005:

Patch Set 5: Code-Review+2

As a side effect, it also updates other repos.

We'll have to update them eventually anyway, so that's fine. It's better than editing that file by hand.

LGTM. Thanks!


Please don’t reply on this GitHub thread. Visit golang.org/cl/129075.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 17, 2018
To integrate with go-github api changes that breaks the compiling:

- google/go-github#910
- google/go-github#972

Change-Id: I5597f50b9c44fe42acec1128617a25e1fdd09e10
GitHub-Last-Rev: 07754f9
GitHub-Pull-Request: #11
Reviewed-on: https://go-review.googlesource.com/129075
Reviewed-by: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/129075 has been merged.

@gopherbot gopherbot closed this Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants