Skip to content

Commit d96e584

Browse files
committed
[release-branch.go1.18] net: disable TestLookupDotsWithRemoteSource and TestLookupGoogleSRV
These tests fail consistently due to a DNS change causing widespread trybot outages. For #56707. Fixes #56709. Change-Id: Iebdf91254a922a48880021198f0f12f6bc16b6e7 Reviewed-on: https://go-review.googlesource.com/c/go/+/449640 Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Run-TryBot: Michael Knyszek <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Damien Neil <[email protected]> (cherry picked from commit 9776524) Reviewed-on: https://go-review.googlesource.com/c/go/+/449505 Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent a3dce12 commit d96e584

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/net/lookup_test.go

+8
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,10 @@ var lookupGoogleSRVTests = []struct {
7171
var backoffDuration = [...]time.Duration{time.Second, 5 * time.Second, 30 * time.Second}
7272

7373
func TestLookupGoogleSRV(t *testing.T) {
74+
// TODO(mknyszek): Figure out next steps for this test. This is just
75+
// a quick fix.
76+
t.Skip("fails consistently due to an upstream DNS change; see #56707.")
77+
7478
t.Parallel()
7579
mustHaveExternalNetwork(t)
7680

@@ -631,6 +635,10 @@ func TestLookupDotsWithLocalSource(t *testing.T) {
631635
}
632636

633637
func TestLookupDotsWithRemoteSource(t *testing.T) {
638+
// TODO(mknyszek): Figure out next steps for this test. This is just
639+
// a quick fix.
640+
t.Skip("fails consistently due to an upstream DNS change; see #56707.")
641+
634642
if runtime.GOOS == "darwin" || runtime.GOOS == "ios" {
635643
testenv.SkipFlaky(t, 27992)
636644
}

0 commit comments

Comments
 (0)