Skip to content

net: builders failing TestLookupDotsWithRemoteSource and TestLookupGoogleSRV due to missing host for _xmpp-server._tcp.google.com #56707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Nov 11, 2022 · 13 comments
Closed

net: builders failing TestLookupDotsWithRemoteSource and TestLookupGoogleSRV due to missing host for _xmpp-server._tcp.google.com #56707

bcmills opened this issue Nov 11, 2022 · 13 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.20

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 11, 2022 •
edited
Loading 

#!watchflakes
post <- pkg == "net" && test == "TestLookupGoogleSRV"

--- FAIL: TestLookupDotsWithRemoteSource (0.32s)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 169.254.169.254:53: no such host (mode=go)
    lookup_test.go:708: LookupSRV(xmpp-server, tcp, google.com): lookup _xmpp-server._tcp.google.com on 169.254.169.254:53: no such host (mode=cgo)
--- FAIL: TestLookupGoogleSRV (36.06s)
    lookup_test.go:93: backoff 1s after failure lookup _xmpp-server._tcp.google.com on 169.254.169.254:53: no such host
    lookup_test.go:93: backoff 5s after failure lookup _xmpp-server._tcp.google.com on 169.254.169.254:53: no such host
    lookup_test.go:93: backoff 30s after failure lookup _xmpp-server._tcp.google.com on 169.254.169.254:53: no such host
    lookup_test.go:99: lookup _xmpp-server._tcp.google.com on 169.254.169.254:53: no such host
FAIL
FAIL	net	39.011s

greplogs -l -e xmpp-server --since=2022-11-01
2022-11-11T16:04:21-fcd14bd/darwin-amd64-11-aws
2022-11-11T16:04:21-fcd14bd/illumos-amd64
2022-11-11T16:04:21-fcd14bd/linux-386
2022-11-11T16:04:21-fcd14bd/linux-386-buster
2022-11-11T16:04:21-fcd14bd/linux-amd64-goamd64v3
2022-11-11T16:04:21-fcd14bd/linux-amd64-staticlockranking
2022-11-11T16:04:21-fcd14bd/linux-arm64
2022-11-11T16:04:21-fcd14bd/linux-arm64-aws
2022-11-11T16:04:21-fcd14bd/netbsd-386-9_0
2022-11-11T16:04:21-fcd14bd/openbsd-386-68
2022-11-11T16:04:21-fcd14bd/windows-386-2012
2022-11-11T16:04:21-fcd14bd/windows-amd64-2008
2022-11-11T16:04:21-fcd14bd/windows-amd64-2016-newcc
2022-11-11T16:04:21-fcd14bd/windows-amd64-newcc-race
2022-11-11T16:04:21-fcd14bd/windows-arm64-10
2022-11-11T16:04:21-fcd14bd/windows-arm64-11
2022-11-11T14:51:14-fffda6b/linux-386-sid
2022-11-10T18:46:00-fbf763f/plan9-arm
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Nov 11, 2022
@bcmills bcmills added this to the Go1.20 milestone Nov 11, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Nov 11, 2022

(attn @ianlancetaylor @neild; CC @mknyszek)

@bcmills bcmills pinned this issue Nov 11, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/449640 mentions this issue: net: disable TestLookupDotsWithRemoteSource and TestLookupGoogleSRV

@mknyszek mknyszek unpinned this issue Nov 11, 2022
@mknyszek mknyszek mentioned this issue Nov 11, 2022
Closed
@mknyszek
Copy link
Contributor

Filed #56708 to follow-up.

@heschi
Copy link
Contributor

heschi commented Nov 11, 2022

Needs backporting?

@mknyszek
Copy link
Contributor

I think so, yeah.

@mknyszek
Copy link
Contributor

@gopherbot Please backport this issue to Go 1.18 and Go 1.19. It's causing widespread builder failures.

This was referenced Nov 11, 2022
Closed
Closed
@gopherbot
Copy link
Contributor

Backport issue(s) opened: #56709 (for 1.18), #56710 (for 1.19).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/449505 mentions this issue: [release-branch.go1.18] net: disable TestLookupDotsWithRemoteSource and TestLookupGoogleSRV

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/449506 mentions this issue: [release-branch.go1.19] net: disable TestLookupDotsWithRemoteSource and TestLookupGoogleSRV

gopherbot pushed a commit that referenced this issue Nov 11, 2022
@mknyszek
[release-branch.go1.18] net: disable TestLookupDotsWithRemoteSource a…
d96e584 
…nd TestLookupGoogleSRV

These tests fail consistently due to a DNS change causing widespread
trybot outages.

For #56707.
Fixes #56709.

Change-Id: Iebdf91254a922a48880021198f0f12f6bc16b6e7
Reviewed-on: https://go-review.googlesource.com/c/go/+/449640
Reviewed-by: Carlos Amedee <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
(cherry picked from commit 9776524)
Reviewed-on: https://go-review.googlesource.com/c/go/+/449505
Reviewed-by: Ian Lance Taylor <[email protected]>
gopherbot pushed a commit that referenced this issue Nov 11, 2022
@mknyszek
[release-branch.go1.19] net: disable TestLookupDotsWithRemoteSource a…
c653979 
…nd TestLookupGoogleSRV

These tests fail consistently due to a DNS change causing widespread
trybot outages.

For #56707.
Fixes #56710.

Change-Id: Iebdf91254a922a48880021198f0f12f6bc16b6e7
Reviewed-on: https://go-review.googlesource.com/c/go/+/449640
Reviewed-by: Carlos Amedee <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
(cherry picked from commit 9776524)
Reviewed-on: https://go-review.googlesource.com/c/go/+/449506
Reviewed-by: Ian Lance Taylor <[email protected]>
@qmuntal
Copy link
Member

qmuntal commented Nov 15, 2022 •
edited
Loading

@mknyszek @bcmills Should this be backported to boring branches? Tests are failing there too and will hit this issue when cutting a new release. Additionally, this is already blocking our (Microsoft) Go fork CI pipeline.

@qmuntal qmuntal mentioned this issue Nov 15, 2022
Merged
@heschi
Copy link
Contributor

heschi commented Nov 15, 2022

We'll do boringcrypto merges as part of the minor release process in a couple weeks.

@bcmills bcmills mentioned this issue Nov 17, 2022
Closed
andrew-d pushed a commit to tailscale/go that referenced this issue Dec 7, 2022
@mknyszek @andrew-d
[release-branch.go1.19] net: disable TestLookupDotsWithRemoteSource a…
2cd8ffe 
…nd TestLookupGoogleSRV

These tests fail consistently due to a DNS change causing widespread
trybot outages.

For golang#56707.
Fixes golang#56710.

Change-Id: Iebdf91254a922a48880021198f0f12f6bc16b6e7
Reviewed-on: https://go-review.googlesource.com/c/go/+/449640
Reviewed-by: Carlos Amedee <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
Run-TryBot: Michael Knyszek <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
(cherry picked from commit 9776524)
Reviewed-on: https://go-review.googlesource.com/c/go/+/449506
Reviewed-by: Ian Lance Taylor <[email protected]>
@golang golang locked and limited conversation to collaborators Jan 10, 2024
@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestLookupGoogleSRV"
2024-03-27 19:24 linux-loong64-3a5000 go@efb7cc42 net.TestLookupGoogleSRV (log) 
2024/03/28 03:35:27 killing splice client after 5 second shutdown timeout
panic: test timed out after 3m0s
running tests:
	TestCloseRead (10s)
	TestCloseWrite (10s)
	TestConnClose (10s)
	TestListenerClose (10s)
	TestLookupGmailMX (10s)
	TestLookupGmailNS (10s)
	TestLookupGmailTXT (10s)
...
	/tmp/workdir-host-linux-loong64-3a5000/go/src/net/lookup.go:713 +0x20c fp=0xc000403ca8 sp=0xc000403098 pc=0x120192b1c
net.(*Resolver).lookupSRV(...)
	/tmp/workdir-host-linux-loong64-3a5000/go/src/net/lookup_unix.go:104
net.(*Resolver).LookupSRV(0x12049cae0, {0x120333ea0, 0x1204cbbc0}, {0x1202d3deb, 0x4}, {0x1202d3c1a, 0x3}, {0x1202d5aef, 0xa})
	/tmp/workdir-host-linux-loong64-3a5000/go/src/net/lookup.go:515 +0x78 fp=0xc000403d80 sp=0xc000403ca8 pc=0x120191aa8
net.LookupSRV({0x1202d3deb, 0x4}, {0x1202d3c1a, 0x3}, {0x1202d5aef, 0xa})
	/tmp/workdir-host-linux-loong64-3a5000/go/src/net/lookup.go:497 +0x80 fp=0xc000403e08 sp=0xc000403d80 pc=0x1201919e0
net.TestLookupGoogleSRV(0xc000332b60)
	/tmp/workdir-host-linux-loong64-3a5000/go/src/net/lookup_test.go:89 +0x194 fp=0xc000403f68 sp=0xc000403e08 pc=0x1201f5014
testing.tRunner(0xc000332b60, 0x1202ec3f0)

— watchflakes

@gopherbot gopherbot reopened this Mar 28, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 7, 2024
@dmitshur
Copy link
Member

dmitshur commented May 7, 2024

This issue was fixed in Go1.20 milestone and frozen, with Soon label. The new failure mode is different, and watchflakes probably shouldn't reopen frozen issues (filed #67232 for that). I'll take it out of the Test Flakes project to avoid that happening again.

@dmitshur dmitshur closed this as completed May 7, 2024
@dmitshur dmitshur removed this from Test Flakes May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
6 participants
@mknyszek @dmitshur @qmuntal @bcmills @gopherbot @heschi