Skip to content

Commit e4e29ee

Browse files
author
Bryan C. Mills
committed
[release-branch.go1.12] cmd/go/internal/modfetch: remove non-hermetic test
The test for gopkg.in/yaml.v2@v2 assumes that there are no future upstream releases. That assumption empirically does not hold. Backporting fixes to this test is annoying, and other gopkg.in cases are already reasonably covered, so remove the problematic test. Updates #28856 Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17 Reviewed-on: https://go-review.googlesource.com/c/go/+/205437 Run-TryBot: Bryan C. Mills <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]> (cherry picked from commit f0390ff) Reviewed-on: https://go-review.googlesource.com/c/go/+/205439 Reviewed-by: Alexander Rakoczy <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent 741cb42 commit e4e29ee

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

src/cmd/go/internal/modfetch/coderepo_test.go

-9
Original file line numberDiff line numberDiff line change
@@ -283,15 +283,6 @@ var codeRepoTests = []struct {
283283
time: time.Date(2016, 12, 8, 18, 13, 25, 0, time.UTC),
284284
gomod: "module gopkg.in/check.v1\n",
285285
},
286-
{
287-
path: "gopkg.in/yaml.v2",
288-
rev: "v2",
289-
version: "v2.2.5-0.20191002202810-970885f01c8b",
290-
name: "970885f01c8bc1fecb7ab1c8ce8e7609bda45530",
291-
short: "970885f01c8b",
292-
time: time.Date(2019, 10, 2, 20, 28, 10, 0, time.UTC),
293-
gomod: "module \"gopkg.in/yaml.v2\"\n\nrequire (\n\t\"gopkg.in/check.v1\" v0.0.0-20161208181325-20d25e280405\n)\n",
294-
},
295286
{
296287
path: "vcs-test.golang.org/go/mod/gitrepo1",
297288
rev: "master",

0 commit comments

Comments
 (0)