godoc should compute actual method set

[rsc]

type foo struct { }

// Doc comment
func (f *foo) Method()

type T struct {
    foo
}

It would be nice if godoc showed Method as a method of T.

There is code in package net that could be simplified by
using embedded types, but it is not, because doing so would
lose method documentation.

[griesemer]

Comment 1:

Doing this reasonably correctly will require a significant rewrite of the current
documentation extraction mechanism: Non-exported AST nodes are stripped via
ast.PackageExports (or ast.FileExports), at which point non-exported anonymous fields
are not present anymore even if they have exported methods and are used inside exported
structs. Thus, at this point, the go.doc code cannot associate exported methods of
non-exported anonymous fields with the exported type containing those fields. At best,
we can do it for exported anonymous fields, and even then, the field types must be
defined locally (in the same package).
A 100% correct solution will require full type information.

[rsc]

Comment 2:

We don't need a 100% correct solution, but it would be
very helpful to handle the case of an embedded unexported field.
Even if it means special handling for that one case, not
being able to get docs for those methods is complicating
some code that would otherwise be simpler (package net
comes to mind), all just to get doc comments.

[rsc]

Comment 3:

Labels changed: added priority-later.

[rsc]

Comment 4:

Labels changed: added priority-go1.

[griesemer]

Comment 5:

This issue was closed by revision 9535b86.

Status changed to Fixed.

[rsc]

Comment 6:

Yay!