Skip to content

syscall: Dup3/Dup2/Dup should not use RawSyscall #10202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jacobsa opened this issue Mar 20, 2015 · 1 comment
Closed

syscall: Dup3/Dup2/Dup should not use RawSyscall #10202

jacobsa opened this issue Mar 20, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@jacobsa
Copy link
Contributor

jacobsa commented Mar 20, 2015

These syscalls may block if there is a FUSE file system involved, causing them to camp on GOMAXPROCS credit. See this thread for details and discussion.
@minux minux added this to the Go1.5 milestone Mar 20, 2015
ianlancetaylor added a commit to golang/sys that referenced this issue Mar 26, 2015
@ianlancetaylor
unix: change Dup,Dup2,Dup3 to use Syscall, not RawSyscall
5829c74 
This avoids hanging when a Go program uses a FUSE filesystem and the
dup system call has to close a file descriptor.  When dup uses
RawSyscall then the goroutine calling dup will occupy a scheduler slot
(a p structure) during the call, and may block waiting for some other
goroutine to respond to the close call on the FUSE filesystem.
Changing to Syscall avoids the problem.  This makes Dup a tiny bit
slower but is quite unlikely to make a difference for any real
programs.

Update golang/go#10202.

Change-Id: I590c5c9a04e0a1281a85dc553c7592fa83949ac7
Reviewed-on: https://go-review.googlesource.com/8056
Reviewed-by: Rob Pike <[email protected]>
@jacobsa
Copy link
Contributor Author

jacobsa commented Mar 26, 2015

Just for the record, I see that you hit golang.org/x/sys/unix with golang/sys@5829c74, too. Thank you!

@jacobsa jacobsa mentioned this issue Jun 10, 2015
Open
@ianlancetaylor ianlancetaylor mentioned this issue Jun 15, 2016
Closed
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
4 participants
@minux @jacobsa @ianlancetaylor @gopherbot