Skip to content

all: vet output for core is noisy #11041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
robpike opened this issue Jun 2, 2015 · 41 comments
Closed

all: vet output for core is noisy #11041

robpike opened this issue Jun 2, 2015 · 41 comments
Labels
FrozenDueToAge
Milestone
Go1.8

Comments

@robpike
Copy link
Contributor

robpike commented Jun 2, 2015

Find a way to run vet regularly on the official go tree(s) and make it quiet.

This will require some scripting and cleanups.
@robpike robpike added this to the Go1.6 milestone Jun 2, 2015
@minux minux mentioned this issue Jun 8, 2015
Closed
@rsc rsc modified the milestones: Go1.7Early, Go1.6 Dec 5, 2015
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/19824 mentions this issue.

gopherbot pushed a commit that referenced this issue Feb 23, 2016
@ALTree @bradfitz
regexp: remove unreachable code
cd41db3 
Found running go vet on the package. It barks that
	regexp/backtrack.go:257: unreachable code
	regexp/backtrack.go:302: unreachable code

For #11041

Change-Id: I0f5ba0d6183108fba3d144991b826273db0ffb09
Reviewed-on: https://go-review.googlesource.com/19824
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/20002 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 2, 2016
@0xmohit @bradfitz
net: fix vet warnings
1c94e72 
Updates #11041

Change-Id: I12c20beab75d7981efe470eb418e4b58dc8eb066
Reviewed-on: https://go-review.googlesource.com/20002
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/20684 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/20685 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/22091 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 14, 2016
@josharian
crypto/aes: fix vet warnings in gcm_amd64.s
096c900 
Notably, this fixes two incorrect argument sizes.

Update #11041

Change-Id: Ie4a3b1a59cd6a6707f6d2f4d3be978fc70322b46
Reviewed-on: https://go-review.googlesource.com/22091
Run-TryBot: Josh Bleecher Snyder <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/22318 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 28, 2016
@valyala @robpike
cmd/vet: improve checking unkeyed fields in composite literals
22db3c5 
- Simplified the code.

- Removed types for slice aliases from composite literals' whitelist, since they
are properly handled by vet.

Fixes #15408
Updates #9171
Updates #11041

Change-Id: Ia1806c9eb3f327c09d2e28da4ffdb233b5a159b0
Reviewed-on: https://go-review.googlesource.com/22318
Run-TryBot: Rob Pike <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Rob Pike <[email protected]>
@bradfitz bradfitz modified the milestones: Go1.7Maybe, Go1.7Early May 6, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/23082 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/23083 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/23080 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/23081 mentions this issue.

gopherbot pushed a commit that referenced this issue May 12, 2016
@valyala @bradfitz
reflect: fix vet warnings
a715849 
Updated #11041

Change-Id: I4a110ba8fefb367a1049b4a65dd20c39eb890ea2
Reviewed-on: https://go-review.googlesource.com/23080
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
gopherbot pushed a commit that referenced this issue May 12, 2016
@valyala @bradfitz
cmd: fixed certain vet warnings
376e641 
Updates #11041

Change-Id: I7f2583d08f344d6622027c5e8a5de1f5d2f2881c
Reviewed-on: https://go-review.googlesource.com/23082
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
gopherbot pushed a commit that referenced this issue May 12, 2016
@valyala @bradfitz
testing: fix vet warning
e54dfc2 
Updates #11041

Change-Id: I32a381854e6a4fd791db380150efab57e6dfc38c
Reviewed-on: https://go-review.googlesource.com/23081
Reviewed-by: Brad Fitzpatrick <[email protected]>
gopherbot pushed a commit that referenced this issue May 12, 2016
@valyala @bradfitz
go/types: fix certain vet warnings
ccf2c01 
Updates #11041

Change-Id: I4e1c670d2b7fc04927d77c6f933cee39b7d48b6e
Reviewed-on: https://go-review.googlesource.com/23083
Reviewed-by: Brad Fitzpatrick <[email protected]>
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@rsc rsc modified the milestones: Go1.8, Go1.7Maybe May 17, 2016
@josharian josharian mentioned this issue Jun 30, 2016
Closed
@josharian
Copy link
Contributor

I am going to fix this for Go 1.8. Every time I check there are legitimate failures.

@josharian josharian self-assigned this Jun 30, 2016
@josharian josharian mentioned this issue Jul 10, 2016
Closed
gopherbot pushed a commit that referenced this issue Aug 21, 2016
@josharian
cmd/vet: re-quote struct tags when printing errors
65c5d62 
cmd/link/link_test.go contains several multi-line
struct tags. Going through an unquote/quote cycle
converts `a
b
c` to "a\nb\nc\n".

This keeps all vet error messages for the standard
library on a single line.

Updates #11041

Change-Id: Ifba1e87297a5174294d1fbf73463fd3db357464f
Reviewed-on: https://go-review.googlesource.com/27129
Run-TryBot: Josh Bleecher Snyder <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Rob Pike <[email protected]>
gopherbot pushed a commit that referenced this issue Aug 22, 2016
@josharian
cmd/vet: improve asmdecl parameter handling
4af1148 
The asmdecl check had hand-rolled code that
calculated the size and offset of parameters
based only on the AST.
It included a list of known named types.

This CL changes asmdecl to use go/types instead.
This allows us to easily handle named types.
It also adds support for structs, arrays,
and complex parameters.

It improves the default names given to unnamed
parameters. Previously, all anonymous arguments were
called "unnamed", and the first anonymous return
argument was called "ret".
Anonymous arguments are now called arg, arg1, arg2,
etc., depending on the index in the argument list.
Return arguments are ret, ret1, ret2.

This CL also fixes a bug in the printing of
composite data type sizes.

Updates #11041

Change-Id: I1085116a26fe6199480b680eff659eb9ab31769b
Reviewed-on: https://go-review.googlesource.com/27150
Run-TryBot: Josh Bleecher Snyder <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Rob Pike <[email protected]>
gopherbot pushed a commit that referenced this issue Aug 22, 2016
@josharian
cmd/vet: clean up printing errors with no position
0952a15 
Before:

: runtime/asm_amd64.s:345: [amd64] morestack: use of 8(SP) points beyond argument frame

After:

runtime/asm_amd64.s:345: [amd64] morestack: use of 8(SP) points beyond argument frame

Updates #11041

Change-Id: Ic87a6d1a2a7b2a8bf737407bc981b159825c84f2
Reviewed-on: https://go-review.googlesource.com/27152
Run-TryBot: Josh Bleecher Snyder <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Rob Pike <[email protected]>
gopherbot pushed a commit that referenced this issue Aug 22, 2016
@josharian
cmd/vet: improve error message for cross-package assembly
f410a66 
bytes.Compare has its go prototype in package bytes,
but its implementation in package runtime.
vet used to complain that the prototype was missing.
Now instead:

runtime/asm_amd64.s:1483: [amd64] cannot check cross-package assembly function: Compare is in package bytes

Updates #11041

Change-Id: Ied44fac10d0916d7a34e552c02d052e16fca0c8c
Reviewed-on: https://go-review.googlesource.com/27153
Run-TryBot: Josh Bleecher Snyder <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Rob Pike <[email protected]>
gopherbot pushed a commit that referenced this issue Aug 22, 2016
@josharian
cmd/vet: fix mips64le arch name in asmdecl check
863ca99 
Updates #11041

Change-Id: Ic6df8ef25b7cf280db523950cd3640b060ad1a9b
Reviewed-on: https://go-review.googlesource.com/27157
Run-TryBot: Josh Bleecher Snyder <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
Reviewed-by: Rob Pike <[email protected]>
gopherbot pushed a commit that referenced this issue Aug 22, 2016
@josharian
cmd/vet: handle multiple arches in asm build directives
ef6fde2 
If a build directive contains multiple arches,
try to match the build context.

Updates #11041

Change-Id: I03b5d7bfb29d1ff6c7d36a9d7c7fabfcc1d871c1
Reviewed-on: https://go-review.googlesource.com/27158
Run-TryBot: Josh Bleecher Snyder <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Rob Pike <[email protected]>
gopherbot pushed a commit that referenced this issue Aug 22, 2016
@josharian
runtime: cull dead code
7c5f33b 
They are unused, and vet wants them to have
a function prototype.

Updates #11041

Change-Id: Idedc96ddd3c3cf1b1d2ab6d98796367eab29f032
Reviewed-on: https://go-review.googlesource.com/27492
Run-TryBot: Josh Bleecher Snyder <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/27493 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/27490 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/27491 mentions this issue.

gopherbot pushed a commit that referenced this issue Aug 22, 2016
@josharian
runtime: ignore closeonexec ret val on openbsd/arm
e80376c 
Fixes #16641
Updates #11041

Change-Id: I087208a486f535d74135591b2c9a73168cf80e1a
Reviewed-on: https://go-review.googlesource.com/27490
Run-TryBot: Josh Bleecher Snyder <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
gopherbot pushed a commit that referenced this issue Aug 22, 2016
@josharian
runtime: use correct MOV for plan9 brk_ ret value
5abfc97 
Updates #11041

Change-Id: I78f8d48f00cfbb451e37c868cc472ef06ea0fd95
Reviewed-on: https://go-review.googlesource.com/27491
Run-TryBot: Josh Bleecher Snyder <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
gopherbot pushed a commit that referenced this issue Aug 22, 2016
@josharian
crypto/*, runtime: nacl asm fixes
e2103ad 
Found by vet.

Updates #11041

Change-Id: I5217b3e20c6af435d7500d6bb487b9895efe6605
Reviewed-on: https://go-review.googlesource.com/27493
Run-TryBot: Josh Bleecher Snyder <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/27713 mentions this issue.

gopherbot pushed a commit that referenced this issue Aug 25, 2016
@josharian
all: fix assembly vet issues
71ab9fa 
Add missing function prototypes.
Fix function prototypes.
Use FP references instead of SP references.
Fix variable names.
Update comments.
Clean up whitespace. (Not for vet.)

All fairly minor fixes to make vet happy.

Updates #11041

Change-Id: Ifab2cdf235ff61cdc226ab1d84b8467b5ac9446c
Reviewed-on: https://go-review.googlesource.com/27713
Run-TryBot: Josh Bleecher Snyder <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/27811 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/27810 mentions this issue.

gopherbot pushed a commit that referenced this issue Aug 25, 2016
@josharian
net/http, cmd/compile: minor vet fixes
f9acd39 
Updates #11041

Change-Id: Ia0151723e3bc0d163cc687a02bfc5e0285d95ffa
Reviewed-on: https://go-review.googlesource.com/27810
Run-TryBot: Josh Bleecher Snyder <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
josharian added a commit to josharian/go that referenced this issue Aug 31, 2016
@josharian
cmd/vet: ignore comments in assembly
b92816b 
Prior to this, a comment like

//	12(SP)	siginfo style

would trigger a spurious complaint from vet.

Updates golang#11041

Change-Id: I2224d7ab564d0ed9a25f28489f4673f9b7193007
josharian added a commit to josharian/go that referenced this issue Aug 31, 2016
@josharian
cmd/vet: add vet runner script for core
5191425 
This CL adds a script to run vet on std and cmd.

There are a considerable number of false positives,
mostly from legitimate but unusual assembly in
the runtime and reflect packages.

There are also a few false positives that need fixes.
They are noted as such in the whitelists;
they're not worth holding this CL for.

The unsafe pointer check is disabled.
The false positive rate is just too high to be worth it.

There is no cmd/dist/test integration yet.
The tentative plan is that we'll check the local platform
during all.bash, and that there'll be a fast builder that
checks all platforms (to cover platforms that can't exec).

Fixes golang#11041

Change-Id: Iee4ed32b05447888368ed86088e3ed3771f84442
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/28344 mentions this issue.

gopherbot pushed a commit to golang/net that referenced this issue Sep 1, 2016
@bradfitz
http2: fix all vet warnings
1358eff 
Updates golang/go#16228
Updates golang/go#11041

Change-Id: I2b50c2f4bfaae2d9ad59bc78e1c7c3e807f08075
Reviewed-on: https://go-review.googlesource.com/28344
Run-TryBot: Brad Fitzpatrick <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/29110 mentions this issue.

gopherbot pushed a commit that referenced this issue Sep 13, 2016
@bradfitz
net/http: update bundled x/net/http2
802cb59 
Updates x/net/http2 (and x/net/lex/httplex) to git rev 749a502 for:

   http2: don't sniff first Request.Body byte in Transport until we have a conn
   https://golang.org/cl/29074
   Fixes #17071

   http2: add Transport support for unicode domain names
   https://golang.org/cl/29071
   Updates #13835

   http2: don't send bogus :path pseudo headers if Request.URL.Opaque is set
   https://golang.org/cl/27632
     +
   http2: fix bug where '*' as a valid :path value in Transport
   https://golang.org/cl/29070
   Updates #16847

   http2: fix all vet warnings
   https://golang.org/cl/28344
   Updates #16228
   Updates #11041

Also uses the new -underscore flag to x/tools/cmd/bundle from
https://golang.org/cl/29086

Change-Id: Ica0f6bf6e33266237e37527a166a783d78c059c4
Reviewed-on: https://go-review.googlesource.com/29110
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Chris Broadfoot <[email protected]>
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/37614 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue Feb 28, 2017
@bradfitz
cmd/coordinator: add a misc-vet-vetall to the trybot set
eb12582 
vet checks for all. josharian rejoices.

Updates golang/go#11041

Change-Id: I1877c0523ba14bbe3a181323aa9ff058797fc4ab
Reviewed-on: https://go-review.googlesource.com/37614
Reviewed-by: Josh Bleecher Snyder <[email protected]>
@golang golang locked and limited conversation to collaborators Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
5 participants
@bradfitz @josharian @rsc @robpike @gopherbot