Skip to content

all: decide how to spell the past tense of cancel #11626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robpike opened this issue Jul 8, 2015 · 17 comments
Closed

all: decide how to spell the past tense of cancel #11626

robpike opened this issue Jul 8, 2015 · 17 comments
Milestone

Comments

@robpike
Copy link
Contributor

robpike commented Jul 8, 2015

Both the gerund and the past participle of cancel appear with both one and with two l's. Be consistent and also correct. Check the dictionary.

@robpike robpike self-assigned this Jul 8, 2015
@robpike robpike added this to the Go1.6 milestone Jul 8, 2015
@sprstnd
Copy link

sprstnd commented Jul 8, 2015

Both are acceptable in American English and British English. Just discourage the use of inflection(styling) - as cancellation doesn't seem to have an inflected variant.
cancel
cancelled
cancelling
cancellation

@robpike
Copy link
Contributor Author

robpike commented Jul 8, 2015

The key phrase in the issue opener was "be consistent".

@sprstnd
Copy link

sprstnd commented Jul 9, 2015

And that is why I suggested to discourage inflection, as cancellation doesn't seem to have an inflected form. All suffix forms of cancel would be consistent, with two l's. cancel, cancelled, cancelling, cancellation.

But you also implied that one style was incorrect too- within that same sentence. And that is where I corrected you- both styles are correct and acceptable in both American English and British English.

@theckman
Copy link
Contributor

theckman commented Jul 9, 2015

Looking at Google search results for cancelation makes it seem widespread enough that it should be considered valid. If you even ask the engine to define it, it provides a valid definition. Based on that, I have no objections with choosing the single l form.

@robpike
Copy link
Contributor Author

robpike commented Jul 10, 2015

Whatever you think I implied, what I said was, "check the dictionary". I wanted to be sure to be correct. Google searches are good at finding usage, and there are arguments that common usage is always correct, but if it's easy to obey what the dictionary claims is true, why not do that?

@mwhudson
Copy link
Contributor

Which dictionary do you mean though? The OED only has "cancelled", Mirriam-Webster says both "cancelled" and "canceled" are OK. My understanding is that "canceled" is predominant but not universal in the USA and not used in other English speaking countries (I find canceled looks wrong, but I grew up in the UK and live in NZ so that's not surprising).

@robpike
Copy link
Contributor Author

robpike commented Jul 10, 2015

mwhudson: See issue #11626. :)

@sprstnd
Copy link

sprstnd commented Jul 10, 2015

I tried to make this clear as possible. Stating that both forms are ACCEPTABLE and CORRECT in both American English and British English. I am suggesting discourage inflection and use the long form, as cancellation doesn't seem to have an accepted inflected variant. And I am not talking about google searches of web pages, blogs, and such- I am strictly speaking about academia. As in my previous posts, I suggest using the long form so that all the suffixed variants of cancel are consistent. - cancel, cancelling, cancelled, cancellation.

There are arguments for each side. I stated my opinion- not much else to argue. It boils down to the nitty gritty of taste. robpike will do what robpike does, its your task commander assignee.

Interesting data sets can be produced using Ngrams: https://books.google.com/ngrams
Maybe experiment before making your decision.

@sprstnd
Copy link

sprstnd commented Jul 10, 2015

what you said was, "Both the gerund and the past participle of cancel appear with both one and with two l's. Be consistent and also correct. Check the dictionary." That statement implied that the use of suffixed forms of cancel were used in BOTH an inconsistent and incorrect manner. I merely corrected you by stating that both are acceptable, and now I'll add that, its a matter of taste. I am sorry I bruised your ego, it was not my intention to turn this into a pissing match.

@sprstnd
Copy link

sprstnd commented Jul 10, 2015

theckman suggested the use of short form. stating that cancelation seemed to be widely used. However this data set suggest otherwise:
https://books.google.com/ngrams/graph?content=cancellation%2Ccancelation&year_start=1800&year_end=2008&corpus=15&smoothing=0&share=&direct_url=t1%3B%2Ccancellation%3B%2Cc0%3B.t1%3B%2Ccancelation%3B%2Cc0

@cespare
Copy link
Contributor

cespare commented Jul 27, 2015

The OED only recognizes 'cancelled' which is the preferred spelling everywhere that isn't the US.

All the other dictionaries I looked at (Merriam-Webster, American Heritage, wiktionary) list both 'canceled' and 'cancelled'.

The ngram results discussed above as well as lots of other online sources suggest that 'canceled' is more prevalent in American usage and 'cancelled' is nigh-universal elsewhere.

The AP style guide recommends 'canceled'.

I'd say go with 'canceled':

  • Dictionaries support either choice
  • The Go documentation prefers American spellings already (exhibit A: image/color)
  • It is one character shorter than the alternative

@theckman
Copy link
Contributor

@cespare I hadn't even thought to check other uses of words like that in the codebase. 👍 on 'canceled'

@sprstnd
Copy link

sprstnd commented Jul 27, 2015

I'd still like to point out that cancellation doesn't seem to have an inflected variant. using the long form keeps all suffixed forms consistent. As these forms could used in future documentation it may be prudent decision making.

cancel, cancelling,cancelled, cancellation

Also, one could make the argument that all forms of cancel, inflected or not, are so widely accepted that this nitpicking is futile.

@theckman
Copy link
Contributor

As I understand it cancelation is perfectly valid in respect to Americanized English. And we already use American spellings according to @cespare. Seems reasonable to me.

However we decide, I'm sure we can all 👍 consistency.

@sprstnd
Copy link

sprstnd commented Jul 27, 2015

I've already made the argument that it is valid(widely accepted), however I also pointed out that its not widely used like the other inflected suffixed variants of cancel.

But maybe this project can be a turning point for the use of cancelation.

just a side note. my browsers spell checking doesn't recognized 'cancelation', however it accepts all other inflected suffixed variants of cancel. I'll check other spell checking software for the same behavior.

even a google search suggests that 'cancelation' may be wrong, and suggests searching the term 'cancellation' instead. It doesn't behave the same with the other inflected variants of cancel.

wiktionary makes a case for cancelation but doesn't cite anything. the discussion page mentions rules within the language forbidding the long form but again doesn't cite anything. So now I'm investigating such rules.
https://en.wiktionary.org/wiki/cancelation

however, using ngrams I have access to a data set with millions of entries that convey just the opposite.

Like I said before, it is a matter of taste, I'm just making the argument for commonality among existing American/British English work.

I really don't care what form is used, i just find this an interesting topic. It just happened to start in an issue regarding golang.

@mvdan
Copy link
Member

mvdan commented Sep 4, 2015

Android uses a single l always, e.g. Activity.RESULT_CANCELED. I think it would make sense to follow their example.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/24683 mentions this issue.

gopherbot pushed a commit that referenced this issue Jun 30, 2016
We had ~30 one way, and these four new occurrences the other way.

Updates #11626

Change-Id: Ic6403dc4905874916ae292ff739d33482ed8e5bf
Reviewed-on: https://go-review.googlesource.com/24683
Reviewed-by: Rob Pike <[email protected]>
@golang golang locked and limited conversation to collaborators Jun 30, 2017
@rsc rsc unassigned robpike Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants