Skip to content

x/build: submit queue, possibly implemented as optional auto-submit on +2 when trybots/slowbots with rebase pass #12482

Open
@minux

Description

@minux

I see a trend of giving +2 together with trybot recently.
because we've defined that +2 means it's ok to submit,
I wonder if trybot could just submit the change (on behave
of the user who gives +2 and also invokes the trybot) if
the trybot runs are successful.

what do you think?

Activity

bradfitz

bradfitz commented on Sep 3, 2015

@bradfitz
Contributor

Russ does not want automatic submission for his own CLs, but he's fine with it for others.

We could add a new checkbox.

added
Buildersx/build issues (builders, bots, dashboards)
on Sep 3, 2015
bradfitz

bradfitz commented on Sep 3, 2015

@bradfitz
Contributor

/cc @adg

minux

minux commented on Sep 3, 2015

@minux
MemberAuthor
adg

adg commented on Sep 4, 2015

@adg
Contributor

Until we can have the trybots automatically rebase on the HEAD before running, I don't think this is wise. Am I being paranoid?

mwhudson

mwhudson commented on Sep 4, 2015

@mwhudson
Contributor

On 4 September 2015 at 14:09, Andrew Gerrand notifications@github.com
wrote:

Until we can have the trybots automatically rebase on the HEAD before
running, I don't think this is wise. Am I being paranoid?

I don't think so.

minux

minux commented on Sep 4, 2015

@minux
MemberAuthor

On Thu, Sep 3, 2015 at 10:09 PM, Andrew Gerrand notifications@github.com
wrote:

Until we can have the trybots automatically rebase on the HEAD before
running, I don't think this is wise. Am I being paranoid?

If that could cause problems, then it will also affect us now because there
is no
way for a human reviewer to notice anything unusual before clicking the
submit
button. The trybot could do a few more checks before submission though.

If we do want to implement, we need to make sure that the trybot will only
try to
submit the revision that the trybot has been run on.

added this to the Unreleased milestone on Oct 23, 2015
self-assigned this
on May 12, 2017
changed the title [-]gerrit: automatic submission if trybot passes and +2 given?[/-] [+]x/build: optional auto-submit on +2 when trybots (with rebase) pass[/+] on May 12, 2017
bradfitz

bradfitz commented on May 12, 2017

@bradfitz
Contributor

See also: #9858 (rebase when testing)

16 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Buildersx/build issues (builders, bots, dashboards)FeatureRequestIssues asking for a new feature that does not need a proposal.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bradfitz@josharian@rsc@minux@mwhudson

        Issue actions

          x/build: submit queue, possibly implemented as optional auto-submit on +2 when trybots/slowbots with rebase pass · Issue #12482 · golang/go