cmd/pprof: Dots and slashes aren't allowed in profile names

[rhysh]

The docs for runtime/pprof.NewProfile suggest a particular naming format for custom profiles.

The convention is to use a 'import/path.' prefix to create separate name spaces for each package.

The cmd/pprof tool does not load profiles named with that convention, giving the error "parsing profile: unrecognized profile format".

I'd expect go tool pprof to successfully load profiles made using the runtime/pprof package and its instructions. The regexp that's supposed to match custom profiles, \A(\w+) profile: total \d+\n\z, should match the format described in the runtime/pprof docs.

The full variety of import paths may be too much to support, but at the very least '.' and '/' should be allowed.

$ go version
go version devel +321a407 Fri Nov 6 15:16:28 2015 +0000 darwin/amd64

[rsc]

/cc @matloob

[rsc]

Now that we've got support for generating binary profiles, we should use that for all the profiles we generate. Then the legacy parsing code here won't matter.

[josharian]

Never generating legacy profiles will take a bit more work; see e.g. #18641.

[rsc]

It's fine to generate them when debug=1. That's not the problem here.

[Sajmani]

Upstream PR pending review: google/pprof#81

[rauls5382]

I've merged the fix into the upstream pprof, and will include it in my upcoming rebase of golang pprof.

+1 to generating profiles in profile.proto format, though.

[Sajmani]

OK, then I won't touch cmd/pprof on the Go end; I'll leave that to your rebase. Per your comment on the PR, I'll send a CL to update runtime/pprof on the permitted names.

…

On Tue, Feb 7, 2017 at 1:07 PM Raul Silvera ***@***.***> wrote: I've merged the fix into the upstream pprof, and will include it in my upcoming rebase of golang pprof. +1 to generating profiles in profile.proto format, though. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#13195 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJSK3TwZcaqpXF-tNP4iiDho2bn1YYzNks5raLLIgaJpZM4Ge5vt> .

[Sajmani]

https://go-review.googlesource.com/36533 updates the runtime/pprof docs.