You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I may ask, this is going to entail us adding MaxIdleTimeout and MaxActiveTimeout to Server, right? And also we'll add defaults as you in have in CL 19159, true?
Or should we just expose a new function IdleTimeoutHook so that it takes these durations which if <= 0 means we should use the default durations?
@odeke-em, the naming here is much easier if we don't consider HTTP/2 and PING frames as activity. Then we'd just call it IdleTimeout and be done with it.
But with HTTP/2, do we care about clients sending a PING or other useless frame every N seconds vs. actually sending real requests every N seconds? If so, we need names for both types of idle (network idle vs no-HTTP-requests idle). Or we define IdleTimeout to mean one thing, and give ReadTimeout the other meaning (see #16958 (comment))?
Opinions welcome. Ideally with sample documentation you'd tell users.
I got as far as:
// ReadTimeout optionally specifies a maximum duration before
// timing out reads of request headers. It does not include
// request bodies. For requests after the first on a
// connection, this is timer starts upon receiving the first
// byte. For keep-alive duration, see IdleTimeout.
ReadTimeout time.Duration
// IdleTime, is, uh....
IdleTimeout time.Duration
Activity
gopherbot commentedon Feb 3, 2016
CL https://golang.org/cl/19159 mentions this issue.
http2/h2demo: update bug link, add idle conn timeouts
odeke-em commentedon Apr 4, 2016
If I may ask, this is going to entail us adding
MaxIdleTimeout
andMaxActiveTimeout
to Server, right? And also we'll add defaults as you in have in CL 19159, true?Or should we just expose a new function IdleTimeoutHook so that it takes these durations which if <= 0 means we should use the default durations?
gopherbot commentedon Apr 4, 2016
CL https://golang.org/cl/21491 mentions this issue.
bradfitz commentedon Sep 1, 2016
@odeke-em, the naming here is much easier if we don't consider HTTP/2 and PING frames as activity. Then we'd just call it
IdleTimeout
and be done with it.But with HTTP/2, do we care about clients sending a
PING
or other useless frame every N seconds vs. actually sending real requests every N seconds? If so, we need names for both types of idle (network idle vs no-HTTP-requests idle). Or we defineIdleTimeout
to mean one thing, and giveReadTimeout
the other meaning (see #16958 (comment))?Opinions welcome. Ideally with sample documentation you'd tell users.
I got as far as:
/cc @rhysh @broady @adg @bmizerany
bradfitz commentedon Sep 1, 2016
/cc @prabrisat1 too.
24 remaining items