x/tools/refactor/rename: TestMoves is failing on Windows

[bradfitz]

--- FAIL: TestMoves (0.01s)
    mvpkg_test.go:403: -from "b" -to "x/a": unexpected warnings:
        \go\src\conflict\0.go:4:8: renaming this imported package name "b" to "a"
        \go\src\conflict\0.go:3:8:  conflicts with imported package name in same block
        \go\src\conflict\0.go:3:8: skipping update of this file
        want:
        /go/src/conflict/0.go:4:8: renaming this imported package name "b" to "a"
        /go/src/conflict/0.go:3:8:  conflicts with imported package name in same block
        /go/src/conflict/0.go:3:8: skipping update of this file
    mvpkg_test.go:418: -from "b" -to "x/a": rewritten file /go/src/ok/0.go does not match expectation; got <<<package ok

        import a "x\\a"

        var _ a.B
        >>>
        want <<<package ok

        import "x/a"

        var _ a.B
        >>>
    mvpkg_test.go:418: -from "b" -to "x/a": rewritten file /go/src/conflict/0.go does not match expectation; got <<<package conflict

        import "a"
        import a "x\\a"

        var _ a.A
        var _ b.B
        >>>
        want <<<package conflict

        import "a"
        import "x/a"

        var _ a.A
        var _ b.B
        >>>
    mvpkg_test.go:395: -from "x/foo" -to "y/foo": unexpected error: invalid move destination: y/foo; package or subpackage x/foo already exists
Renamed 1 occurrence in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 3 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 2 files in 2 packages.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 4 occurrences in 1 file in 1 package.
Renamed 4 occurrences in 1 file in 1 package.
Renamed 4 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 3 occurrences in 2 files in 2 packages.
Renamed 3 occurrences in 2 files in 2 packages.
Renamed 3 occurrences in 2 files in 2 packages.
Renamed 5 occurrences in 1 file in 1 package.
Renamed 5 occurrences in 1 file in 1 package.
Renamed 3 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
FAIL
FAIL    golang.org/x/tools/refactor/rename  0.213s

/cc @quentinmit (feel free to file bugs like this for all subrepo failures if none exist)

[gopherbot]

CL https://golang.org/cl/24941 mentions this issue.

[adonovan]

Looks like two separate issues, both related to forward vs. backslashes as directory separators:

• the import declaration uses backslashes (a bug in the package)
• the actual warnings in the test use backslashes (a bug in the test)

[gopherbot]

CL https://golang.org/cl/24969 mentions this issue.

[gopherbot]

CL https://golang.org/cl/32392 mentions this issue.