Skip to content

x/tools/go/gcimporter: update export data format version #17734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
griesemer opened this issue Nov 2, 2016 · 5 comments
Closed

x/tools/go/gcimporter: update export data format version #17734

griesemer opened this issue Nov 2, 2016 · 5 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@griesemer
Copy link
Contributor

Tracking issue.

x/tools/go/gcimporter15/bexport.go still generates export data format version 1, but now that we can export aliases, we should probably update to the latest version. This is not urgent, but may avoid confusion down the road.
@griesemer griesemer added this to the Unreleased milestone Nov 2, 2016
@griesemer griesemer self-assigned this Nov 2, 2016
@griesemer
Copy link
Contributor Author

cc: @alandonovan

@griesemer griesemer changed the title go/gcimporter: update export data format version x/tools/go/gcimporter: update export data format version Nov 2, 2016
@alandonovan
Copy link
Contributor

It is somewhat urgent. For example, Google's source code tools must understand Go 1.8 source and export data before we can start to evaluate 1.8rc1, which will ideally be a long time before the 1.8 release.

@griesemer
Copy link
Contributor Author

We should still do this, even w/o aliases. We should have all importers understand the latest version.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/33111 mentions this issue.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/33113 mentions this issue.

gopherbot pushed a commit to golang/tools that referenced this issue Nov 11, 2016
@griesemer
go/gcimporter15: update build tags and comments
c959b77 
We don't support Go1.5 anymore.

Tested with 1.6, 1.7, and tip.

For golang/go#17734.

Change-Id: I718c7996b99f9b98744346e119ee209b4709a070
Reviewed-on: https://go-review.googlesource.com/33111
Reviewed-by: Alan Donovan <[email protected]>
@golang golang locked and limited conversation to collaborators Nov 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@alandonovan @griesemer @gopherbot