Skip to content

all: inconsistent spelling: canceling or cancelling #17938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikioh opened this issue Nov 16, 2016 · 5 comments
Closed

all: inconsistent spelling: canceling or cancelling #17938

mikioh opened this issue Nov 16, 2016 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@mikioh
Copy link
Contributor

mikioh commented Nov 16, 2016

canceling:

./src/net/http/h2_bundle.go:	http2errStopReqBodyWriteAndCancel = errors.New("http2: canceling request")
./src/net/http/transport.go:		var timer *time.Timer // for canceling TLS handshake
./src/net/http/transport_test.go:	eventLog.Printf("canceling")
./src/net/http/transport_test.go:canceling
./src/net/dial_unix_test.go:			t.Logf("canceling context")

cancelling:

./src/context/context_test.go:	checkChildren("after cancelling WithCancel child", ctx, 0)
./src/context/context_test.go:	checkChildren("after cancelling WithTimeout child", ctx, 0)
./src/os/exec/exec_test.go:			t.Fatal("cancelling context did not stop program")
@dsnet
Copy link
Member

dsnet commented Nov 16, 2016

Related #11626.

Other inconsistencies:

  • panicing vs panicking
  • big-endian vs big endian
  • gray vs grey
  • behavior vs behaviour

@mikioh mikioh changed the title all: inconsistency spelling: canceling or cancelling all: inconsistent spelling: canceling or cancelling Nov 16, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 16, 2016
@quentinmit quentinmit added this to the Go1.8Maybe milestone Nov 16, 2016
@dgryski
Copy link
Contributor

dgryski commented Nov 17, 2016

Maybe overkill, but could the trybots or git-codereview have a test for this?

@griesemer
Copy link
Contributor

The 1-l approach seems more common in Go source, though personally (and I'm not a native speaker), the 2-l solution looks more correct to me (probably because I'm not a native speaker).

One more data point: Bose sells noise cancelling head phones... ( https://www.bose.com/en_us/products/headphones/over_ear_headphones/quietcomfort-25-acoustic-noise-cancelling-headphones-apple-devices.html )

@bradfitz bradfitz self-assigned this Dec 8, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/34147 mentions this issue.

@bradfitz
Copy link
Contributor

bradfitz commented Dec 8, 2016

Not sure why this is Go 1.8 material, but .... https://go-review.googlesource.com/34147

Doing gray/grey (we should use "gray", the American spelling) and big-endian vs big endian are too invasive for now. I did the canceling and easy bits @dsnet mentioned.

@golang golang locked and limited conversation to collaborators Dec 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

7 participants