install: Windows: MSI Upgrade should default to previous install folder, not insist on C:\Go\

[lkarlslund]

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

1.9 release

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

Windows

What did you do?

Had Go 1.9rc2 installed in C:\Program Files\Go
Wizard asked if I wanted to uninstall old during upgrade, I chose YES
Wizard asks where I want to install new version, defaults to C:\Go\

What did you expect to see?

I expected it to suggest installation in the previously selected folder, as this is an upgrade, and everything in environment is set for that path.

What did you see instead?

It insists on suggesting C:\Go\ which fills up my root folder with more directories. I don't get it why you don't use Program Files as everything else on Windows. This is not Linux (and you would never suggest to install in /go/ on a Linux system anyway)

[ianlancetaylor]

CC @broady

[as]

The utility will have to remember where the previous installation occured. How would it do this?

[lkarlslund]

It could write the install path to HKLM/Software/Golang/InstallPath (or whatever you are using now) when installing. Next install reads it, and suggests that. If key is missing, it just uses default folder like now.

…

________________________________ Fra: as <[email protected]> sendt: 11. sep. 2017 10.42 PM til: golang/go Cc: Lars Karlslund; Author Emne: Re: [golang/go] install: Windows: MSI Upgrade should default to previous install folder, not insist on C:\Go\ (#21609) The utility will have to remember where the previous installation occured. How would it do this? - You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#21609 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIhB-2AQj7sUi6myQD6cw8LJURsQqNxwks5shZsegaJpZM4PChEe>.

[as]

That may be a good option. It seems the installer already places a gift in the registry:

reg query HKCU\software\goprogramminglanguage /v installLocation

HKEY_CURRENT_USER\software\goprogramminglanguage
    installLocation    REG_SZ    C:\Go\

Someone with MSI expertise can take it from here.

[as]

Just for the record, I really like C:\go, especially since you can shorten it to \go. Please don't change the default.

Windows has a Program Files (x86), a ProgramData, a System32 and a SysWow64. There is a 32-bit Notepad.exe in the SysWow64 folder and a 64-bit notepad in the System32 folder. The simplicity of C:\go is deeply appreciated on this system.

[iwdgo]

Default location is now %ProgramFiles%\Go

This seems incidentally solved by #18680.

[tamasd]

This is still a problem for me. I have Go installed under S:\Go, but every time I update, the installer wants to install it under C:\Program Files\Go. I checked the registry, and the installLocation correctly points to S:\Go.