net: UDPConn.WriteMsgUDP fails on Windows XP

[alexbrainman]

new windows-386-xp builder on https://build.golang.org fails at commit 29cb57c

https://build.golang.org/log/e18744bedc520329ee61476194bf5020a66ba706

with

--- FAIL: TestUDPConnSpecificMethods (0.02s)
	protoconn_test.go:142: write udp4 127.0.0.1:1138->127.0.0.1:1138: wsasendmsg: An invalid argument was supplied.
--- FAIL: TestWriteToUDP (0.00s)
	udpsock_test.go:168: write udp 127.0.0.1:1282: wsasendmsg: An invalid argument was supplied.
FAIL
FAIL	net	10.336s

As I explained at #10267 (comment) I think we should just skip correspondent parts of the test on Windows XP.

Alex

[bradfitz]

What's the proper way to detect XP?

[alexbrainman]

What's the proper way to detect XP?

Search for isWindowsXP in main repo.

I am going to send a fix for this in a little while. Please wait.

Alex

[alexbrainman]

@bradfitz do we have Windows XP trybot?

Alex

[gopherbot]

Change https://golang.org/cl/83076 mentions this issue: internal/testenv: introduce IsWindowsXP

[gopherbot]

Change https://golang.org/cl/83077 mentions this issue: net: skip some tests on Windows XP

[bradfitz]

@alexbrainman, no trybot. We just have a single XP VM currently. Maybe @johnsonj will get Windows Server 2003 working on GCE and then we could have an opt-in Trybot or something.

[alexbrainman]

Cool, I will test my change here, and then we'll submit and see.

Alex

[alexbrainman]

I really do not know how to fix this - I am not even sure if it is possible to fix. I am just skipping broken tests for the moment.

Alex

[bradfitz]

@alexbrainman, that's fine.