Skip to content

x/build: finish, document Gerrit hashtags for managing open CLs #24836

Open
@bradfitz

Description

@bradfitz

In chat with @andybons @FiloSottile @bcmills and @ianlancetaylor yesterday, I proposed we start using Gerrit's "hashtags" support, now that our hosted Gerrit supports it (notedb support is active for us) and PolyGerrit (the new web UI) supports it.

After discussion, we settled on using tags:

so, how about: "wait-author", "wait-release", "wait-issue", "wait-$PERSON"
where $PERSON is some substring of a name/email in the reviewer set.
and if somebody is named "Issue Release" and their email is issue@release.com, then you have to use their full email in $PERSON
we can mass remove the "wait-release" labels when tree opens

While triaging today, I found we should also add support for:

wait-cl-NNNNN -- this CL is blocked until NNN is resolved

I started looking into adding hashtag support to maintner and gopherbot.

Tracking that work here, then documenting all this on the wiki.

Activity

added
DocumentationIssues describing a change to documentation.
NeedsFixThe path to resolution is known, but the work has not been done.
on Apr 13, 2018
self-assigned this
on Apr 13, 2018
added this to the Unreleased milestone on Apr 13, 2018
added
Buildersx/build issues (builders, bots, dashboards)
on Apr 13, 2018
gopherbot

gopherbot commented on Apr 13, 2018

@gopherbot
Contributor

Change https://golang.org/cl/106795 mentions this issue: gerrit: add support for hashtags

FiloSottile

FiloSottile commented on Apr 13, 2018

@FiloSottile
Contributor

Also wait-issue-NNNNN. I guess the number can be implicit when the issue is linked from the commit message.

bradfitz

bradfitz commented on Apr 13, 2018

@bradfitz
ContributorAuthor

@FiloSottile, yup, I just found that too and just tagged an issue with that, for a CL that had an open proposal but wasn't mentioned in the commit message.

added a commit that references this issue on Apr 13, 2018
gopherbot

gopherbot commented on Apr 15, 2018

@gopherbot
Contributor

Change https://golang.org/cl/107297 mentions this issue: maintner: add hashtag mutation accessors on GerritMeta

gopherbot

gopherbot commented on Apr 16, 2018

@gopherbot
Contributor

Change https://golang.org/cl/107305 mentions this issue: maintner: track hashtag edits on GerritMeta, make HashtagEdits method faster

bcmills

bcmills commented on Apr 16, 2018

@bcmills
Contributor

I think I must be missing something, but how do I add hashtags from the Gerrit UI?

bradfitz

bradfitz commented on Apr 16, 2018

@bradfitz
ContributorAuthor

@bcmills, left bar of the PolyGerrit UI:
screen shot 2018-04-16 at 3 56 12 pm

bradfitz

bradfitz commented on Apr 16, 2018

@bradfitz
ContributorAuthor

Or for the old UI, that little icon on the right:
screen shot 2018-04-16 at 3 57 11 pm

27 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Buildersx/build issues (builders, bots, dashboards)DocumentationIssues describing a change to documentation.NeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    Status

    Planned

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bradfitz@FiloSottile@dmitshur@ALTree@bcmills

        Issue actions

          x/build: finish, document Gerrit hashtags for managing open CLs · Issue #24836 · golang/go