Open
Description
In chat with @andybons @FiloSottile @bcmills and @ianlancetaylor yesterday, I proposed we start using Gerrit's "hashtags" support, now that our hosted Gerrit supports it (notedb support is active for us) and PolyGerrit (the new web UI) supports it.
After discussion, we settled on using tags:
so, how about: "wait-author", "wait-release", "wait-issue", "wait-$PERSON"
where $PERSON is some substring of a name/email in the reviewer set.
and if somebody is named "Issue Release" and their email is issue@release.com, then you have to use their full email in $PERSON
we can mass remove the "wait-release" labels when tree opens
While triaging today, I found we should also add support for:
wait-cl-NNNNN -- this CL is blocked until NNN is resolved
I started looking into adding hashtag support to maintner and gopherbot.
Tracking that work here, then documenting all this on the wiki.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Planned
Relationships
Development
No branches or pull requests
Activity
gopherbot commentedon Apr 13, 2018
Change https://golang.org/cl/106795 mentions this issue:
gerrit: add support for hashtags
FiloSottile commentedon Apr 13, 2018
Also
wait-issue-NNNNN
. I guess the number can be implicit when the issue is linked from the commit message.bradfitz commentedon Apr 13, 2018
@FiloSottile, yup, I just found that too and just tagged an issue with that, for a CL that had an open proposal but wasn't mentioned in the commit message.
gerrit: add support for hashtags
gopherbot commentedon Apr 15, 2018
Change https://golang.org/cl/107297 mentions this issue:
maintner: add hashtag mutation accessors on GerritMeta
maintner: add hashtag mutation accessors on GerritMeta
gopherbot commentedon Apr 16, 2018
Change https://golang.org/cl/107305 mentions this issue:
maintner: track hashtag edits on GerritMeta, make HashtagEdits method faster
bcmills commentedon Apr 16, 2018
I think I must be missing something, but how do I add hashtags from the Gerrit UI?
bradfitz commentedon Apr 16, 2018
@bcmills, left bar of the PolyGerrit UI:

bradfitz commentedon Apr 16, 2018
Or for the old UI, that little icon on the right:

27 remaining items