Skip to content

cmd/go: list {{.Stale}} was not updated for the change to install [1.10 backport] #25026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Apr 23, 2018 · 1 comment
Closed

cmd/go: list {{.Stale}} was not updated for the change to install [1.10 backport] #25026

gopherbot opened this issue Apr 23, 2018 · 1 comment
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.10.2

Comments

@gopherbot
Copy link
Contributor

@FiloSottile requested issue #24558 to be considered for backport to the next 1.10 minor release.

@gopherbot please file this for backport against 1.10. This might be considered a regression (see discussion).
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 23, 2018
@gopherbot gopherbot mentioned this issue Apr 23, 2018
Closed
@gopherbot gopherbot added this to the Go1.10.2 milestone Apr 23, 2018
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/110076 mentions this issue: [release-branch.go1.10] cmd/go: fix go list .Stale computation

@andybons andybons added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Apr 27, 2018
gopherbot pushed a commit that referenced this issue Apr 27, 2018
@rsc @andybons
[release-branch.go1.10] cmd/go: fix go list .Stale computation
11d7a5a 
If X depends on Y and X was installed but Y is only present in the cache
(as happens when you "go install X") then we should report X as up-to-date,
not as stale.

This applies whether X is a package or a main binary.

Fixes #25026
Fixes #25032

Change-Id: I26a0b375b1f7f7ac909cc0db68e92f4e04529208
Reviewed-on: https://go-review.googlesource.com/107957
Run-TryBot: Russ Cox <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
(cherry picked from commit 9e0e698)
Reviewed-on: https://go-review.googlesource.com/110076
Reviewed-by: Ian Lance Taylor <[email protected]>
@golang golang locked and limited conversation to collaborators Apr 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.10.2
Development

No branches or pull requests
2 participants
@andybons @gopherbot