syscall: many tests failing due to ENOSYS Pipe on js,wasm

[bradfitz]

https://build.golang.org/log/bf6cae84b57c5946f94da6f3291cb90281882f34

On js/wasm, syscall/fs_js.go is:

func Pipe(fd []int) error {
        return ENOSYS
}

That causes many tests to fail.

I thought we were going to use the nacl code here? Did too much of that get ripped out?

/cc @neelance

[neelance]

I thought we were going to use the nacl code here? Did too much of that get ripped out?

The eventual decision was to remove all FD mapping logic and to use FDs given by Node.js directly. Since Node.js has no support for os.Pipe, it had to become unsupported. (Discussion on https://go-review.googlesource.com/c/go/+/109977)

I skipped tests that depend on os.Pipe. However, I'm always running tests with -short, since wasm is terribly slow on the tests that are already considered slow on other architectures. I guess that the failures you see are tests that are not -short.

[bradfitz]

all.bash runs tests with -short.

[neelance]

Found it: What I am also using is -run=Test to exclude Example*. Running examples depends on os.Pipe:

go/src/testing/example.go

Lines 66 to 71 in 05f8b44

	r, w, err := os.Pipe()
	if err != nil {
	fmt.Fprintln(os.Stderr, err)
	os.Exit(1)
	}
	os.Stdout = w

[gopherbot]

Change https://golang.org/cl/119377 mentions this issue: cmd/dist: don't test Examples for js/wasm