Closed
Description
godoc relies on https://golang.org/doc/go1.10#goroot but GAE Classic is still running Go 1.9.
Convert to use GAE Flex so that we can rid ourselves of these limitations (and deploy godoc from the release-branch.go1.11)
Metadata
Metadata
Assignees
Type
Projects
Relationships
Development
No branches or pull requests
Participants
Activity
bradfitz commentedon Aug 24, 2018
Milestone: Go 1.6 :)
bradfitz commentedon Aug 24, 2018
Also, because we're using a Go 1.10 x/tools on golang.org now, certain links don't work from the release notes & blog post, like:
https://golang.org/cmd/go/#hdr-Modules__module_versions__and_more
Because the godoc heading rules. This should be a heading:
Modules, module versions, and more
But it renders as a plain paragraph at the moment.
dmitshur commentedon Aug 24, 2018
Similarly, this statement from https://golang.org/doc/go1.11#godoc is not yet true on https://golang.org/pkg/:
As a workaround, in the meantime, you can refer to https://tip.golang.org/pkg/. E.g.:
https://tip.golang.org/pkg/os/#UserCacheDir
steren commentedon Aug 30, 2018
FYI, Go 1.11 on the App Engine standard environment is coming.
53 remaining items
[release-branch.go1.11] cmd/godoc: add cloud build config
dmitshur commentedon Jan 30, 2019
The task described in the original issue has long been complete. This issue has remained opened because there was one remaining clean up task (see #27205 (comment)):
The work happening in #29206 obsoletes the need for this to be done. /cc @cnoellekb After the golang.org website is deployed from x/website, x/tools/cmd/godoc will be reduced in scope to just serve documentation locally, and its appinit.go will be simply deleted.
That work is better tracked by other open issues, so I'll close this as done.
agnivade commentedon Jan 30, 2019
There were a few others also which weren't done.
Not sure if they would be obsoleted too.
dmitshur commentedon Jan 30, 2019
Thanks for pointing that out, I didn't see those two.
I think this one will either be obsolete or will naturally come up as part of the post-move cleanup process.
I don't see a need to track it via a dedicated issue, but if someone wants to, feel free to open one.Edit: This opportunity is now captured in an open issue at #29206 (comment).I was going to open a new issue for that. I saw that https://golang.org/s pointed to this issue, but didn't find that task which related for it. Opened #29988 to track this.
gopherbot commentedon Jan 30, 2019
Change https://golang.org/cl/160377 mentions this issue:
godoc/short: point to new tracking issue for shortlink creationgodoc/short: point to new tracking issue for shortlink creation
gopherbot commentedon Jan 30, 2019
Change https://golang.org/cl/160477 mentions this issue:
[release-branch.go1.11] godoc/short: point to new tracking issue for shortlink creation[release-branch.go1.11] godoc/short: point to new tracking issue for …