Skip to content

net: empty DNS answers should fail fast #27525

Closed
@iangudger

Description

@iangudger

With Go 1.11, DNS queries which are responded to with an empty answers section will be tried on all name servers. This was not the case with Go 1.10. This is mostly an issue if one of the name servers is broken and results in a timeout.

This issue was first reported here: #21906 (comment)

I am filing a new issue because this is a regression in Go 1.11 and #21906 was filed prior to Go 1.10.

Activity

iangudger

iangudger commented on Sep 6, 2018

@iangudger
ContributorAuthor

This is similar to #25336.

gopherbot

gopherbot commented on Sep 6, 2018

@gopherbot
Contributor

Change https://golang.org/cl/133675 mentions this issue: net: treat no answers as NXDOMAIN

bcmills

bcmills commented on Sep 6, 2018

@bcmills
Contributor

I am filing a new issue because this is a regression in Go 1.11

Should this issue have a backport, then?

added
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
on Sep 6, 2018
added this to the Go1.12 milestone on Sep 6, 2018
iangudger

iangudger commented on Sep 6, 2018

@iangudger
ContributorAuthor

I think backporting the fix would be a good idea.

bcmills

bcmills commented on Sep 6, 2018

@bcmills
Contributor

@gopherbot, please backport to 1.11: this is a regression of a previously-fixed issue.

gopherbot

gopherbot commented on Sep 6, 2018

@gopherbot
Contributor

Backport issue(s) opened: #27537 (for 1.11).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

ssrikant20

ssrikant20 commented on Sep 21, 2018

@ssrikant20

What is the ETA for this issue? This is slowing down DNS responses back to the client causing context deadline to exceed.

iangudger

iangudger commented on Sep 21, 2018

@iangudger
ContributorAuthor

I have been having trouble getting the fix reviewed. Brad is on vacation. Two different people have stated their intent to review it soon, so hopefully the fix will go in next week.

ssrikant20

ssrikant20 commented on Sep 21, 2018

@ssrikant20

I have been having trouble getting the fix reviewed. Brad is on vacation. Two different people have stated their intent to review it soon, so hopefully the fix will go in next week.

Thank you

gopherbot

gopherbot commented on Sep 27, 2018

@gopherbot
Contributor

Change https://golang.org/cl/138175 mentions this issue: [release-branch.go1.11] net: fail fast for DNS rcode success with no answers of requested type

added a commit that references this issue on Nov 30, 2018
locked and limited conversation to collaborators on Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bcmills@iangudger@gopherbot@ssrikant20

        Issue actions

          net: empty DNS answers should fail fast · Issue #27525 · golang/go