Skip to content

reflect: MethodByName().Interface() leads to fatal error: sweep increased allocation count [1.10 backport] #27866

Closed
@gopherbot

Description

@gopherbot

@randall77 requested issue #27695 to be considered for backport to the next 1.10 minor release.

@gopherbot, please open a backport issue please.

This has been broken for a while, but it's a nasty bug. We should consider backporting it.

Activity

added this to the Go1.10.5 milestone on Sep 25, 2018
gopherbot

gopherbot commented on Sep 30, 2018

@gopherbot
ContributorAuthor

Change https://golang.org/cl/138586 mentions this issue: [release-branch.go1.10] reflect: fix s390x reflect method calls

gopherbot

gopherbot commented on Sep 30, 2018

@gopherbot
ContributorAuthor

Change https://golang.org/cl/138585 mentions this issue: [release-branch.go1.10] reflect: ensure correct scanning of return values

gopherbot

gopherbot commented on Sep 30, 2018

@gopherbot
ContributorAuthor

Change https://golang.org/cl/138584 mentions this issue: [release-branch.go1.10] reflect: use correct write barrier operations for method funcs

gopherbot

gopherbot commented on Oct 1, 2018

@gopherbot
ContributorAuthor

Change https://golang.org/cl/138587 mentions this issue: [release-branch.go1.10] runtime: don't dereference 0-length bitvectors

dmitshur

dmitshur commented on Nov 1, 2018

@dmitshur
Member

@randall77 This patch does not apply cleanly to release-branch.go1.10 right now. If you still think this should be backported, can you please make a cherry-pick CL as described at https://golang.org/wiki/MinorReleases#making-cherry-pick-cls?

We can also decide this doesn't meet the backport policy criteria, since there is a workaround (update to Go 1.11.1, where this issue is resolved).

Edit: I'll move the milestone to Go 1.10.6 since it's too late for Go 1.10.5 release that's happening today.

modified the milestones: Go1.10.5, Go1.10.6 on Nov 1, 2018
gopherbot

gopherbot commented on Nov 2, 2018

@gopherbot
ContributorAuthor

Change https://golang.org/cl/147237 mentions this issue: [release-branch.go1.10] reflect: ensure correct scanning of return values

bcmills

bcmills commented on Nov 19, 2018

@bcmills
Contributor

@randall77, given the fix in 1.11 and the proximity to 1.12, is this still worth backporting to 1.10?

added
WaitingForInfoIssue is not actionable because of missing required information, which needs to be provided.
on Nov 26, 2018
modified the milestones: Go1.10.6, Go1.10.7 on Dec 13, 2018

4 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CherryPickCandidateUsed during the release process for point releasesFrozenDueToAgeWaitingForInfoIssue is not actionable because of missing required information, which needs to be provided.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @andybons@FiloSottile@dmitshur@bcmills@gopherbot

        Issue actions

          reflect: MethodByName().Interface() leads to fatal error: sweep increased allocation count [1.10 backport] · Issue #27866 · golang/go