Skip to content

x/perf/benchstat: add -metrics=speed,alloc/op flag #30368

Closed
@nigeltao

Description

@nigeltao

benchstat reports a number of metrics:

  • alloc/op
  • speed
  • time/GC
  • time/op

In my automated reports, I'm only interested in a subset of those, even if the underlying source files provide more than that.

Would you (@aclements) accept a patch so that I can say benchstat -metrics=speed,alloc/op?

Right now, I can workaround it with piping benchstat's output through sed. It's not that onerous, but if others might find it useful, it's possibly a little cleaner to do it in benchstat itself.

Activity

added this to the Unreleased milestone on Feb 23, 2019
added
FeatureRequestIssues asking for a new feature that does not need a proposal.
on Feb 28, 2019
bcmills

bcmills commented on Feb 28, 2019

@bcmills
Contributor
added
NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.
on Feb 28, 2019
josharian

josharian commented on Feb 28, 2019

@josharian
Contributor

Sounds fine to me, but I think this is Austin's call.

gopherbot

gopherbot commented on Nov 4, 2021

@gopherbot
Contributor

Change https://golang.org/cl/309969 mentions this issue: cmd/benchstat: new version of benchstat

added a commit that references this issue on Nov 28, 2021
4845406
locked and limited conversation to collaborators on Jan 13, 2024
added a commit that references this issue on Apr 12, 2024
02c5517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FeatureRequestIssues asking for a new feature that does not need a proposal.FrozenDueToAgeNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @josharian@bcmills@nigeltao@gopherbot

        Issue actions

          x/perf/benchstat: add -metrics=speed,alloc/op flag · Issue #30368 · golang/go