Skip to content

cmd/go: error if GOCACHE is set but is not an absolute path [1.12 backport] #30493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Mar 1, 2019 · 2 comments
Closed

cmd/go: error if GOCACHE is set but is not an absolute path [1.12 backport] #30493

gopherbot opened this issue Mar 1, 2019 · 2 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12.1

Comments

@gopherbot
Copy link
Contributor

@oiooj requested issue #30447 to be considered for backport to the next 1.12 minor release.

@gopherbot please backport to 1.12
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 1, 2019
@gopherbot gopherbot mentioned this issue Mar 1, 2019
Closed
@gopherbot gopherbot added this to the Go1.12.1 milestone Mar 1, 2019
@oiooj oiooj self-assigned this Mar 1, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/164717 mentions this issue: [release-branch.go1.12] cmd/go/internal/cache: disable builds if GOCACHE is not an absolute path

@gopherbot
Copy link
Contributor Author

Closed by merging 162b361 to release-branch.go1.12.

gopherbot pushed a commit that referenced this issue Mar 1, 2019
@oiooj @ianlancetaylor
[release-branch.go1.12] cmd/go/internal/cache: disable builds if GOCA…
162b361 
…CHE is not an absolute path

If GOCACHE is set but is not an absolute path, we cannot build.
And GOCACHE=off also returns the error message "build cache is
disabled by GOCACHE=off".

Fixes #30493

Change-Id: I24f64bc886599ca0acd757acada4714aebe4d3ae
Reviewed-on: https://go-review.googlesource.com/c/164200
Run-TryBot: Baokun Lee <[email protected]>
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Bryan C. Mills <[email protected]>
(cherry picked from commit 13d24b6)
Reviewed-on: https://go-review.googlesource.com/c/164717
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
@golang golang locked and limited conversation to collaborators Feb 29, 2020
@rsc rsc unassigned oiooj Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12.1
Development

No branches or pull requests
2 participants
@oiooj @gopherbot