x/tools/gopls: context cancellation errors in type-checking

[zikaeroh]

Please answer these questions before submitting your issue. Thanks!

What did you do?

Edit my code normally, adding functions, imports, etc.

What did you expect to see?

Completion, diagnostics, etc, continue to work.

What did you see instead?

After a few edits, I'm stuck with "work queue is full" and am forced to reload the editor.

Build info

golang.org/x/tools/cmd/gopls v0.1.3-cmd.gopls
    golang.org/x/tools@v0.0.0-20190815235612-5b08f89bfc0c h1:7eYQMBMvMxbxtNK/jCq9umo/V/QiO5CLoIzIpSYM1i4=
    golang.org/x/sync@v0.0.0-20190423024810-112230192c58 h1:8gQV6CLnAEikrhgkHFbMAEhagSSnXWGV915qUMm9mrU=
    golang.org/x/xerrors@v0.0.0-20190717185122-a985d3407aa7 h1:9zdDQZ7Thm29KFXgAX/+yaf3eVbP7djjWp/dXAppNCc=

Go info

go version go1.12.8 linux/amd64

GOARCH="amd64"
GOBIN=""
GOCACHE="/home/jake/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/jake/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/lib/go"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/jake/zikaeroh/hortbot/hortbot/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build700267818=/tmp/go-build -gno-record-gcc-switches"

Some logs:

[Info  - 9:28:51 PM] 2019/08/15 21:28:51 637.47427ms for GOROOT=/usr/lib/go GOPATH=/home/jake/go GO111MODULE= PWD=/home/jake/zikaeroh/hortbot/hortbot go "list" "-e" "-json" "-compiled=true" "-test=true" "-export=false" "-deps=true" "-find=false" "--" "/home/jake/zikaeroh/hortbot/hortbot/internal/bot", stderr: <<>>

[Info  - 9:28:51 PM] 2019/08/15 21:28:51 go/packages.Load
	packages = 2
[Info  - 9:28:51 PM] 2019/08/15 21:28:51 go/packages.Load
	package = github.com/hortbot/hortbot/internal/bot
	files = [/home/jake/zikaeroh/hortbot/hortbot/internal/bot/access_level.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/accesslevel_string.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/actions.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/autoreplies.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/bot.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/builtin_commands.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_admin.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_autoreplies.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_command.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_filters.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_fun.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_lastfm.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_levels.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_list.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_management.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_moderation.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_quote.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_raffle.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_random.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_repeat.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_schedule.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_settings.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_steam.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_twitch.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_var.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/correlation.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/custom_command.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/deps.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/filters.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/handle.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/helpers.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/interfaces.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/rdb.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/repeat.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/session.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/sessiontype_string.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/testing.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/var.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/access_level_test.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/export_test.go]
[Info  - 9:28:51 PM] 2019/08/15 21:28:51 go/packages.Load
	package = github.com/hortbot/hortbot/internal/bot
	files = [/home/jake/zikaeroh/hortbot/hortbot/internal/bot/access_level.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/accesslevel_string.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/actions.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/autoreplies.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/bot.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/builtin_commands.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_admin.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_autoreplies.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_command.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_filters.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_fun.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_lastfm.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_levels.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_list.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_management.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_moderation.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_quote.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_raffle.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_random.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_repeat.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_schedule.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_settings.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_steam.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_twitch.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_var.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/correlation.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/custom_command.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/deps.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/filters.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/handle.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/helpers.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/interfaces.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/rdb.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/repeat.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/session.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/sessiontype_string.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/testing.go /home/jake/zikaeroh/hortbot/hortbot/internal/bot/var.go]
2019/08/15 21:28:51 failed to check package: check: context canceled
2019/08/15 21:28:51 failed to check package: check: context canceled
2019/08/15 21:28:51 failed to compute diagnostics: no CheckPackageHandles for file:///home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_twitch.go
	file = file:///home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_twitch.go
2019/08/15 21:28:51 failed to check package: check: context canceled
2019/08/15 21:28:51 failed to check package: check: context canceled
2019/08/15 21:28:51 failed to deliver diagnostic for (will not retry): Parse: context canceled
	file = file:///home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_twitch.go
[Error - 9:28:51 PM] 2019/08/15 21:28:51 failed to deliver diagnostic for (will not retry): Parse: context canceled
	file = file:///home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_twitch.go
[Error - 9:28:51 PM] 2019/08/15 21:28:51 failed to check package: check: context canceled
[Error - 9:28:51 PM] 2019/08/15 21:28:51 failed to check package: check: context canceled
[Error - 9:28:51 PM] 2019/08/15 21:28:51 failed to compute diagnostics: no CheckPackageHandles for file:///home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_twitch.go
	file = file:///home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_twitch.go
[Error - 9:28:51 PM] 2019/08/15 21:28:51 failed to check package: check: context canceled
[Error - 9:28:51 PM] 2019/08/15 21:28:51 failed to check package: check: context canceled
[Info  - 9:28:51 PM] 2019/08/15 21:28:51 no completions found
	At = {0xc000226700 13154077 13154077}
	Failure = this is a definition, of const followAut invalid type
2019/08/15 21:28:51 failed to check package: check: context canceled
[Error - 9:28:51 PM] 2019/08/15 21:28:51 failed to check package: check: context canceled
2019/08/15 21:28:51 failed to check package: check: context canceled
2019/08/15 21:28:51 failed to deliver diagnostic (will retry): Parse: context canceled
	file = file:///home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_twitch.go
[Error - 9:28:51 PM] 2019/08/15 21:28:51 failed to check package: check: context canceled
[Error - 9:28:51 PM] 2019/08/15 21:28:51 failed to deliver diagnostic (will retry): Parse: context canceled
	file = file:///home/jake/zikaeroh/hortbot/hortbot/internal/bot/cmd_twitch.go
2019/08/15 21:28:51 failed to check package: check: context canceled
[Error - 9:28:51 PM] 2019/08/15 21:28:51 failed to check package: check: context canceled
2019/08/15 21:28:51 failed to check package: check: context canceled
2019/08/15 21:28:51 failed to check package: check: context canceled
2019/08/15 21:28:51 failed to check package: check: context canceled
work queue is full
work queue is full
work queue is full
work queue is full
work queue is full
work queue is full
work queue is full
work queue is full

[zikaeroh]

Perhaps this is the same as #33531 (but I'm unsure).

[stamblerre]

This is an issue I just introduced with CL 185438. I'm in the process of some pretty large changes, so things may be a bit unstable on master right now. That said, it seems like what's happening here is that we are propagating context cancellation errors from type-checking. I'll try to investigate this a bit further.

[muirdm]

Maybe the CL you mentioned reintroduced the problem where we cache the context.Canceled error in the package cache and it gets stuck that way indefinitely. Can we make it never cache the package on type checker errors like before?

Also, it seems like https://go-review.googlesource.com/c/tools/+/190412 maybe have broken some spots checking explicitly for the context.Canceled error. Perhaps we should use the "%w" error wrapping verb and the checking code should use errors.Is(err, context.Canceled) instead?

[gopherbot]

Change https://golang.org/cl/190601 mentions this issue: internal/lsp: unlabel context, log errors when canceled

[gopherbot]

Change https://golang.org/cl/192719 mentions this issue: internal/lsp: use memoize store's context when type checking

[stamblerre]

I believe that these errors should no longer be an issue, as a lot has changed in the gopls caching and type-checking mechanisms has changed since then.