Skip to content

cmd/go: 'go get cloud.google.com/go@master' chooses a v0.0.0- pseudo-version [1.13 backport] #34477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Sep 23, 2019 · 2 comments
Closed

cmd/go: 'go get cloud.google.com/go@master' chooses a v0.0.0- pseudo-version [1.13 backport] #34477

gopherbot opened this issue Sep 23, 2019 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #34266 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13. This can cause errors in pseudo-version resolution, and the workarounds are not at all obvious.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 23, 2019
@gopherbot gopherbot mentioned this issue Sep 23, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.1 milestone Sep 23, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/197060 mentions this issue: [release-branch.go1.13] cmd/go/internal/modfetch/codehost: work around an apparent bug in 'git fetch --unshallow'

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Sep 25, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 25, 2019
@gopherbot
Copy link
Contributor Author

Closed by merging fb86bbb to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Sep 25, 2019
[release-branch.go1.13] cmd/go/internal/modfetch/codehost: work aroun…
fb86bbb 
…d an apparent bug in 'git fetch --unshallow'

When 'git fetch' is passed the '--unshallow' flag, it assumes that the
local and remote refs are equal.¹ However, we were fetching an
expanded set of refs explicitly in the same command, violating that
assumption.

Now we first expand the set of refs, then unshallow the repo in a
separate fetch. Empirically, this seems to work, whereas the opposite
order does not.

¹https://github.com/git/git/blob/4c86140027f4a0d2caaa3ab4bd8bfc5ce3c11c8a/transport.c#L1303-L1309

Updates #34266
Fixes #34477

Change-Id: Ie97eb7c1223f944003a1e31d0ec9e69aad0efc0d
Reviewed-on: https://go-review.googlesource.com/c/go/+/196961
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Jay Conrod <[email protected]>
(cherry picked from commit 1804bba)
Reviewed-on: https://go-review.googlesource.com/c/go/+/197060
@bcmills bcmills modified the milestones: Go1.13.1, Go1.13.2 Sep 25, 2019
@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@bcmills bcmills mentioned this issue Oct 18, 2019
Closed
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @katiehockman