Skip to content

runtime: high-percentile latency of memory allocations has regressed significantly [1.13 backport] #34556

Closed
@mknyszek

Description

@mknyszek

For some reason gopherbot wouldn't open a backport issue for me. This is a backport of #31678.

The fixes for this (once and for all) have landed in master. https://go-review.googlesource.com/c/go/+/183857/9

The importance of this bug for a 1.13 backport is the fact that it's one of the pieces to the fix for #32828 for Go 1.13, which is a major regression in Kubernetes which is blocking them from landing.

There are two problems with Kubernetes: inline scavenging on the allocation path can really spike allocation tail latencies (this issue) and it could spiral into over-scavenging if fragmentation is not accounted for (#34149).

The fixes for both issues must be landed together to completely fix the issue.

Activity

added this to the Go1.13.2 milestone on Sep 26, 2019
self-assigned this
on Sep 26, 2019
aclements

aclements commented on Oct 2, 2019

@aclements
Member

I agree that we should backport this fix. This and #34149 are blocking k8s from upgrading to Go 1.13.

To be clear, the following two CLs need to be backported for this:
https://go-review.googlesource.com/c/go/+/189957/4
https://go-review.googlesource.com/c/go/+/183857/9

CL 183857 is nearly identical to a change we backported to Go 1.12. CL 189957 is necessary for CL 183857 to be most effective.

added
CherryPickApprovedUsed during the release process for point releases
and removed
CherryPickCandidateUsed during the release process for point releases
on Oct 2, 2019
gopherbot

gopherbot commented on Oct 2, 2019

@gopherbot
Contributor

Change https://golang.org/cl/198485 mentions this issue: [release-branch.go1.13] runtime: grow the heap incrementally

gopherbot

gopherbot commented on Oct 2, 2019

@gopherbot
Contributor

Change https://golang.org/cl/198486 mentions this issue: [release-branch.go1.13] runtime: scavenge on growth instead of inline with allocation

gopherbot

gopherbot commented on Oct 4, 2019

@gopherbot
Contributor

Closed by merging 951dbb1 to release-branch.go1.13.

added a commit that references this issue on Oct 4, 2019
66b8787
locked and limited conversation to collaborators on Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @andybons@mknyszek@aclements@gopherbot@katiehockman

        Issue actions

          runtime: high-percentile latency of memory allocations has regressed significantly [1.13 backport] · Issue #34556 · golang/go