Skip to content

crypto/ecdsa: revert ECDSA assembly on s390x [1.13 backport] #34928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Oct 15, 2019 · 5 comments
Closed

crypto/ecdsa: revert ECDSA assembly on s390x [1.13 backport] #34928

gopherbot opened this issue Oct 15, 2019 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.3

Comments

@gopherbot
Copy link
Contributor

@billotosyr requested issue #34927 to be considered for backport to the next 1.13 minor release.

@gopherbot, please consider backport to 1.13.2
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Oct 15, 2019
@gopherbot gopherbot mentioned this issue Oct 15, 2019
Closed
@gopherbot gopherbot added this to the Go1.13.2 milestone Oct 15, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/201317 mentions this issue: crypto/ecdsa: fix buffer size on s390x for ecdsa

@odeke-em
Copy link
Member

I don't think we meant to close this without a backport.

@odeke-em odeke-em reopened this Oct 16, 2019
@bradfitz bradfitz changed the title crypto/ecdsa: buffers are too small, can cause panic [1.13 backport] crypto/ecdsa: buffers are too small, can cause panic on s390x [1.13 backport] Oct 16, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/201337 mentions this issue: [release-branch.go1.13] crypto/ecdsa: fix buffer size on s390x for ecdsa

@FiloSottile FiloSottile changed the title crypto/ecdsa: buffers are too small, can cause panic on s390x [1.13 backport] crypto/ecdsa: revert ECDSA assembly on s390x [1.13 backport] Oct 16, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/201361 mentions this issue: [release-branch.go1.13] crypto/ecdsa: remove s390x assembly

@bradfitz bradfitz added the CherryPickApproved Used during the release process for point releases label Oct 16, 2019
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 16, 2019
gopherbot pushed a commit that referenced this issue Oct 16, 2019
@mundaym @bradfitz
[release-branch.go1.13] crypto/ecdsa: remove s390x assembly
4cb22ee 
This is a revert of CL 174437 and equivalent to CL 201360.

The size of the params block passed into the KDSA instruction is
incorrect and this appears to result in out-of-bounds writes
that cause a panic in the crypto/x509 tests when run on a machine
that supports KDSA.

Remove this assembly for now. We can revisit the use of the KDSA
instruction in a future release.

Fixes #34928.

Change-Id: I7ad2fe9714b47ad04abc25f18aa235b9d2aef062
Reviewed-on: https://go-review.googlesource.com/c/go/+/201361
Run-TryBot: Michael Munday <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
@FiloSottile
Copy link
Contributor

Fixed by CL 201361

@katiehockman katiehockman modified the milestones: Go1.13.2, Go1.13.3 Oct 17, 2019
@golang golang locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.3
Development

No branches or pull requests
5 participants
@bradfitz @FiloSottile @odeke-em @gopherbot @katiehockman