Closed
Description
What version of Go are you using (go version)?
$ go version go version devel +acf3ff2e8a Tue Dec 3 17:35:06 2019 +0000 linux/amd64 $ go list -m golang.org/x/tools golang.org/x/tools v0.0.0-20191113223546-95cb2a1a7eae => github.com/myitcvforks/tools v0.0.0-20191119111301-0222b4b716c6 $ go list -m golang.org/x/tools/gopls golang.org/x/tools/gopls v0.1.8-0.20191115202509-3a792d9c32b2 => github.com/myitcvforks/tools/gopls v0.0.0-20191119111301-0222b4b716c6
Note that github.com/myitcvforks/tools v0.0.0-20191119111301-0222b4b716c6 and github.com/myitcvforks/tools/gopls v0.0.0-20191119111301-0222b4b716c6 correspond to the x/tools 95cb2a1 with 80313e1 cherry picked on top. Reason being, we can't move beyond 95cb2a1 because otherwise we start tripping over the mistmatched versions problem described in #35114
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env GO111MODULE="on" GOARCH="amd64" GOBIN="" GOCACHE="/home/myitcv/.cache/go-build" GOENV="/home/myitcv/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/myitcv/gostuff" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/home/myitcv/gos" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build319932305=/tmp/go-build -gno-record-gcc-switches"
What did you do?
Was running a govim test and I spotted a data race:
WARNING: DATA RACE
Read at 0x00c00036e880 by goroutine 535:
golang.org/x/tools/internal/memoize.(*Handle).run.func1()
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/memoize/memoize.go:197 +0x47
Previous write at 0x00c00036e880 by goroutine 329:
golang.org/x/tools/internal/memoize.(*Handle).run.func1()
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/memoize/memoize.go:212 +0x143
Goroutine 535 (running) created at:
golang.org/x/tools/internal/memoize.(*Handle).run()
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/memoize/memoize.go:196 +0x18a
golang.org/x/tools/internal/memoize.(*Handle).Get()
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/memoize/memoize.go:179 +0x183
golang.org/x/tools/internal/lsp/cache.(*parseGoHandle).Parse()
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/lsp/cache/parse.go:76 +0x80
golang.org/x/tools/internal/lsp/cache.typeCheck.func1()
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/lsp/cache/check.go:257 +0xaf
Goroutine 329 (finished) created at:
golang.org/x/tools/internal/memoize.(*Handle).run()
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/memoize/memoize.go:196 +0x18a
golang.org/x/tools/internal/memoize.(*Handle).Get()
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/memoize/memoize.go:179 +0x183
golang.org/x/tools/internal/lsp/cache.(*parseGoHandle).Parse()
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/lsp/cache/parse.go:76 +0x80
golang.org/x/tools/internal/lsp/cache.typeCheck.func1()
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/lsp/cache/check.go:257 +0xaf
==================
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xdf8314]
goroutine 995 [running]:
golang.org/x/tools/internal/memoize.(*Handle).run.func1(0xc00036e840, 0x11d3320, 0xc000cfcf00)
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/memoize/memoize.go:197 +0x64
created by golang.org/x/tools/internal/memoize.(*Handle).run
/home/travis/gopath/pkg/mod/github.com/myitcvforks/[email protected]/internal/memoize/memoize.go:196 +0x18b
What did you expect to see?
No data race 😄
What did you see instead?
As above
cc @stamblerre