Skip to content

x/build/cmd/releasebot: Beta release should always run tests #36171

Closed
@toothrot

Description

@toothrot

The releasebot skips running tests in mode=release, as we have normally run tests on the commit we're about to release. For beta releases, it's possible that a commit has been merged to master between the time we've run mode=prepare and mode=release.

Activity

added this to the Unreleased milestone on Dec 16, 2019
added
Buildersx/build issues (builders, bots, dashboards)
on Dec 16, 2019
added
NeedsFixThe path to resolution is known, but the work has not been done.
on Dec 16, 2019
self-assigned this
on Dec 16, 2019
gopherbot

gopherbot commented on Dec 16, 2019

@gopherbot
Contributor

Change https://golang.org/cl/211583 mentions this issue: cmd/releasebot: run tests in mode=release for betas

toothrot

toothrot commented on Dec 17, 2019

@toothrot
ContributorAuthor

Long-term solution captured in #36182

gopherbot

gopherbot commented on May 30, 2020

@gopherbot
Contributor

Change https://golang.org/cl/235777 mentions this issue: cmd/releasebot: use same master commit for beta releases

locked and limited conversation to collaborators on May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Buildersx/build issues (builders, bots, dashboards)FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @toothrot@gopherbot

        Issue actions

          x/build/cmd/releasebot: Beta release should always run tests · Issue #36171 · golang/go