x/tools/gopls: reduce memory usage

[stamblerre]

This is a general tracking issue for memory usage in gopls. We need to collect data and set goals for usage for a given project size. We also need to work towards reducing the memory usage when staticcheck is enabled (though that may be a separate issue).

If you have a specific problem with gopls using too much memory on your machine, please create a new issue so that we can investigate it separately.

Please include your editor settings and memory debug information with your issue. These are automatically written to the temporary directory (/tmp for Unixes) with names like gopls.1234-5GiB-withnames.zip. If you are uncomfortable sharing the package names of your code, you can share the -nonames zip instead.

[nghialm269]

I just upgrade gopls to v0.3.0 today so that I'm able to rename symbols / find reference across package, but the memory usage is very high:

Edit: It's a small private project, the only dependency is beego

I'm using Ubuntu 16.04

gopls version:

golang.org/x/tools/gopls v0.3.0
golang.org/x/tools/gopls@v0.3.0 h1:l9KKK1/n6CIbfgaUvHBWAvCfOxcl1N+KSOK79OlPIao=

go version:

go1.13.4 linux/amd64

[patrikeh]

As the commenter above, I've have had problems with massive memory usage since upgrading to 0.3.0 yesterday, sometimes upward of 12 GB.

macOS Mojave 10.14.6
go version go1.13 darwin/amd64
golang.org/x/tools/gopls@v0.3.0 h1:l9KKK1/n6CIbfgaUvHBWAvCfOxcl1N+KSOK79OlPIao=

[guiguan]

same here :(

[myitcv]

@guiguan there is absolutely no need for language like that. Please, keep the feedback constructive.

FWIW this has already been fixed on master via https://go-review.googlesource.com/c/tools/+/217677

[stamblerre]

I'm sorry that you all encountered this bug - we had a memory leak that was a bit tricky to reproduce, but as @myitcv said, we believe that we've fixed it. You can try it out by downloading the pre-release for the next version of gopls (GO111MODULE=on go get golang.org/x/tools/gopls@v0.3.1-pre1). Please report here if you still see the excessive memory usage with that version.

[vincepri]

@stamblerre On the latest master, gopls is using more than 30GB when developing with some kubernetes sub-projects

[heschi]

@vincepri per the bold section in the original issue, please file a new issue with repro instructions, even if they're just "check this repository out and open it."