Skip to content

x/tools/gopls: unknown revision error doesn't propagate to diagnostics #38232

Closed
@stamblerre

Description

@stamblerre

In conversation with @ardan-bkennedy, we noticed that adding a require github.com/pkg/errors v0.8.3 caused a diagnostic to get stuck because it was an unknown revision. Error messages should either get propagated, or we should clear diagnostics so they don't appear to be stuck?

Activity

added this to the gopls/v0.4.0 milestone on Apr 3, 2020
added
ToolsThis label describes issues relating to any tools in the x/tools repository.
goplsIssues related to the Go language server, gopls.
on Apr 3, 2020
gopherbot

gopherbot commented on Jul 14, 2020

@gopherbot
Contributor

Change https://golang.org/cl/242159 mentions this issue: internal/lsp: handle unknown revision in go.mod file

gopherbot

gopherbot commented on Jul 14, 2020

@gopherbot
Contributor

Change https://golang.org/cl/242477 mentions this issue: internal/lsp: try to parse diagnostics out of go list errors

locked and limited conversation to collaborators on Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @stamblerre@gopherbot

        Issue actions

          x/tools/gopls: unknown revision error doesn't propagate to diagnostics · Issue #38232 · golang/go