Closed
Description
A few reports of issues with gopls when the user has no internet (one on Slack, one on microsoft/vscode-go#3105).
I wonder if there is a way we can have a regression test this - maybe by configuring something in the environment? @findleyr
Metadata
Metadata
Assignees
Labels
Type
Projects
Relationships
Development
No branches or pull requests
Participants
Activity
findleyr commentedon Apr 15, 2020
Following https://golang.org/cl/228235, the regtests use a proxy within our control. If we have examples of how gopls breaks without a network connection, we should be able to reproduce.
mingoal commentedon Apr 15, 2020
@findleyr
suggest scenario:
in go file, include one package which has no local cache,
goplshang or not?goplshang or not?gopherbot commentedon Nov 30, 2020
Change https://golang.org/cl/274120 mentions this issue:
internal/lsp: disable network access for some go commands1 remaining item
stamblerre commentedon Dec 6, 2020
I believe the only remaining task here is to remove network access for the
go mod tidydiagnostics.@heschik, is there anything else I'm missing?
heschi commentedon Dec 8, 2020
That's it as far as I know.
[-]x/tools/gopls: make sure gopls works without network connection[/-][+]x/tools/gopls: don't access the network for `go mod tidy` diagnostics[/+]internal/lsp: disable network access for some go commands
gopherbot commentedon Feb 5, 2021
Change https://golang.org/cl/289309 mentions this issue:
internal/lsp/cache: disable network for mod tidy diagnostics