Skip to content

crypto/x509: stop looking at first root store #38869

Open
@FiloSottile

Description

@FiloSottile

For some reason, when looking for a CA root store on UNIX we stop at the first good file, still look at directories, and not stop at the first good directory. On most systems the file, if it exists, is a bundling of the roots in the directory, and the directories are for different systems, not for combining.

We should probably make the function exit sooner.

Activity

added
NeedsFixThe path to resolution is known, but the work has not been done.
on May 5, 2020
added this to the Backlog milestone on May 5, 2020
gopherbot

gopherbot commented on May 16, 2020

@gopherbot
Contributor

Change https://golang.org/cl/234257 mentions this issue: crypto/x509: rework how system roots are loaded on unix systems

FiloSottile

FiloSottile commented on Oct 5, 2020

@FiloSottile
ContributorAuthor

Like #39540, let's give crypto/x509 a rest in Go 1.16.

modified the milestones: Backlog, Go1.17 on Oct 5, 2020
dmitshur

dmitshur commented on May 21, 2021

@dmitshur
Member

There's only a week until target date for 1.17 beta 1. I'll move this to Backlog since it doesn't seem someone is actively working on getting this in, but please update the issue if needed.

modified the milestones: Go1.17, Backlog on May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    NeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @FiloSottile@dmitshur@gopherbot

        Issue actions

          crypto/x509: stop looking at first root store · Issue #38869 · golang/go