Skip to content

x/website: doc/install has outdated filename for linux #41232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ipriver opened this issue Sep 5, 2020 · 2 comments
Closed

x/website: doc/install has outdated filename for linux #41232

ipriver opened this issue Sep 5, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@ipriver
Copy link
Contributor

ipriver commented Sep 5, 2020

There is a command on doc/install page that uses an outdated filename that is being shown as an example of how to install go for Linux:
tar -C /usr/local -xzf go1.14.3.linux-amd64.tar.gz

What did you expect to see?

tar -C /usr/local -xzf command should use the latest archive filename for the current go version

What did you see instead?

go1.14.3.linux-amd64.tar.gz filename is statically defined in the markup.
@gopherbot gopherbot added this to the Unreleased milestone Sep 5, 2020
@ipriver ipriver mentioned this issue Sep 5, 2020
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/253118 mentions this issue: doc/install: fix Linux tab installation command

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Sep 8, 2020
@AlexRouSg AlexRouSg mentioned this issue Sep 21, 2020
Closed
@jgeiger-trane
Copy link

Thanks. I searched for x/website since that's the issue that's created for the "Report an issue" on the website.

@golang golang locked and limited conversation to collaborators Sep 21, 2021
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
doc/install: fix Linux tab installation command
2bf8136 
There is a command on doc/install page https://golang.org/doc/install that uses an outdated filename that is being shown as an example of how to install go for Linux:

tar -C /usr/local -xzf go1.14.3.linux-amd64.tar.gz

Currently, there is a button that allows downloading .tar file that include go1.15 and its name is different from the command, so that if you follow installation steps you'll get an error that .tar file wasn't found.

Changes purposed:
Added a function that uses a filename from the "Download" button that can be used to update Linux installation command.
This function could be used in the future for other OSes if there will be a need for adding informational data that may change in the future. So there's no need to update such data in the markup files.
If there's something wrong during running JS code (or JS is disabled in the browser) and the filename couldn't be parsed - the old filename is used as an example like before.

Fixes golang/go#41232

Change-Id: Ie389ce73de5393f151ad739b3e97873e1a9be179
GitHub-Last-Rev: 0a93f69393a0b81ee1d869bfb7df612278479c1b
GitHub-Pull-Request: golang/website#15
Reviewed-on: https://go-review.googlesource.com/c/website/+/253118
Run-TryBot: Steve Traut <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Steve Traut <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

doc/install: fix Linux tab installation command
4 participants
@dmitshur @gopherbot @ipriver @jgeiger-trane