Skip to content

Upgrading go from 1.15.7 to 1.15.8 doesn't use old installation path on Windows #44134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aegoroff opened this issue Feb 6, 2021 · 4 comments

Comments

@aegoroff
Copy link

aegoroff commented Feb 6, 2021

What version of Go are you using (go version)?

go version go1.15.8 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\egr\AppData\Local\go-build
set GOENV=C:\Users\egr\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=D:\code\golang\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=D:\code\golang
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=c:\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\egr\AppData\Local\Temp\go-build202219370=/tmp/go-build

What did you do?

Just upgraded golang from 1.15.7 to 1.15.8 under Windows using msi package. I didn't take into account setup path while doing upgrade first time. So to fix this i had to uninstall Golang and install again using old path (c:\Go)

What did you expect to see?

Go installed to my old path c:\Go

What did you see instead?

Go installed to c:\Program Files\Go

@tmthrgd
Copy link
Contributor

tmthrgd commented Feb 6, 2021

The path change was an intentional result of #42070 as installing under C:\Go is a potential security vulnerability. You might want to take a look at the discussion there.

@aegoroff
Copy link
Author

aegoroff commented Feb 6, 2021

Thank you for the explanation. I see it's due to security reasons (Permissions on c:\go are too weak)

@aegoroff aegoroff closed this as completed Feb 6, 2021
@iwdgo
Copy link
Contributor

iwdgo commented Feb 7, 2021

Installation documentation still mentions c:\Go. Issue is tagged Go 1.16 and was closed without mentioning a backport. No documentation update seems available.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/290309 mentions this issue: content/static/doc: update windows install location doc

gopherbot pushed a commit to golang/website that referenced this issue Feb 8, 2021
Document the new install location changed in CL 283600.

Updates golang/go#42070
Updates golang/go#44134

Change-Id: I987b5219b5877068708344d5809cd5bdd09e1807
Reviewed-on: https://go-review.googlesource.com/c/website/+/290309
Reviewed-by: Alexander Rakoczy <[email protected]>
Trust: Dmitri Shuralyov <[email protected]>
@golang golang locked and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants