Skip to content

x/build/cmd/gomote: add gomote client commands using the new API #48737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
13 tasks done
cagedmantis opened this issue Oct 1, 2021 · 17 comments
Closed
13 tasks done

x/build/cmd/gomote: add gomote client commands using the new API #48737

cagedmantis opened this issue Oct 1, 2021 · 17 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@cagedmantis
Copy link
Contributor

cagedmantis commented Oct 1, 2021 •
edited
Loading

Add gomote commands that use the new API:

  • create
  • destroy
  • gettar
  • list
  • ls
  • ping
  • push
  • put
  • put14
  • puttar
  • rm
  • run
  • ssh

This is a component of the project to revamp the security model used by gomote #47521
@golang/release
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 1, 2021
@cagedmantis cagedmantis added this to the Backlog milestone Oct 1, 2021
@cagedmantis cagedmantis mentioned this issue Oct 2, 2021
Closed
16 tasks
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/397656 mentions this issue: cmd/gomote: add gomote GRPC client and authentication

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/398054 mentions this issue: cmd/gomote: implement GRPC create command

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/398056 mentions this issue: cmd/gomote: implements GRPC list command

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/398055 mentions this issue: cmd/gomote: implements GRPC destroy command

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/398496 mentions this issue: cmd/gomote: implements GRPC run command

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/398495 mentions this issue: cmd/gomote: implements GRPC ls command

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/398696 mentions this issue: cmd/gomote: implements GRPC put14 command

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/398695 mentions this issue: cmd/gomote: implements GRPC ping command

gopherbot pushed a commit to golang/build that referenced this issue Apr 25, 2022
@cagedmantis @gopherbot
cmd/gomote: add gomote GRPC client and authentication
fbf276a 
This change adds the GRPC gomote server client to the gomote client.
It also adds the authentication logic to be used with the gomote server.

For golang/go#47521
For golang/go#48737
Fixes golang/go#48739

Change-Id: If83287e27d59d14056131d6077adc4b1a8e85913
Reviewed-on: https://go-review.googlesource.com/c/build/+/397656
Reviewed-by: Heschi Kreinick <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Run-TryBot: Carlos Amedee <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Apr 27, 2022
@cagedmantis @gopherbot
cmd/gomote: implements GRPC create command
7ddefba 
This change adds the implementation for the the GRPC create command to
the gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: I2a45364f6aac078c5356f60ddccb9e301985c9c1
Reviewed-on: https://go-review.googlesource.com/c/build/+/398054
Reviewed-by: Alex Rakoczy <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
Run-TryBot: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Apr 27, 2022
@cagedmantis @gopherbot
cmd/gomote: implements GRPC destroy command
e75a200 
This change adds the implementation for the the GRPC destroy command to
the gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: I821dd68ee0c38f3a175db30b464e3e4247c04776
Reviewed-on: https://go-review.googlesource.com/c/build/+/398055
Reviewed-by: Heschi Kreinick <[email protected]>
Run-TryBot: Carlos Amedee <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
Reviewed-by: Alex Rakoczy <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Apr 27, 2022
@cagedmantis @gopherbot
cmd/gomote: implements GRPC list command
a03adf4 
This change adds the implementation for the GRPC list command to the
gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: Ie9eea0136e0e22edc43ec67e4bd0f8c5350a3ce8
Reviewed-on: https://go-review.googlesource.com/c/build/+/398056
Auto-Submit: Carlos Amedee <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Carlos Amedee <[email protected]>
Reviewed-by: Alex Rakoczy <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Apr 27, 2022
@cagedmantis @gopherbot
cmd/gomote: implements GRPC ls command
e8268b6 
This change adds the implementation for the GRPC ls command to the
gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: Ie08f26f119e72de69ce5716a47edd9c38b88af9b
Reviewed-on: https://go-review.googlesource.com/c/build/+/398495
Run-TryBot: Carlos Amedee <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Alex Rakoczy <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/405514 mentions this issue: cmd/gomote: implements GRPC ssh command

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/405515 mentions this issue: cmd/gomote: implements GRPC rm command

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/406015 mentions this issue: cmd/gomote: implements GRPC put command

gopherbot pushed a commit to golang/build that referenced this issue May 13, 2022
@cagedmantis @gopherbot
cmd/gomote: implements GRPC run command
14d9977 
This change adds the implementation for the GRPC run command to the
gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: I7e5fe3b66f552a10623d59e84adcea9856fe6683
Reviewed-on: https://go-review.googlesource.com/c/build/+/398496
Reviewed-by: Heschi Kreinick <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
Run-TryBot: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue May 13, 2022
@cagedmantis
cmd/gomote: implements GRPC ping command
120f545 
This change adds the implementation for the GRPC ping command to the
gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: I6bbd7fd5b9f5a3d58063b4c433cab330bbb4259f
Reviewed-on: https://go-review.googlesource.com/c/build/+/398695
Reviewed-by: Alex Rakoczy <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
Run-TryBot: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue May 16, 2022
@cagedmantis
cmd/gomote: implements GRPC ssh command
27920f1 
This change adds the implementation for the GRPC ssh command to the
gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: I1e1f09ad23b0f07d28e0c5d06ad00cb948bb41f8
Reviewed-on: https://go-review.googlesource.com/c/build/+/405514
Reviewed-by: Alex Rakoczy <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
Run-TryBot: Carlos Amedee <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue May 16, 2022
@cagedmantis
cmd/gomote: implements GRPC rm command
d50e6c0 
This change adds the implementation for GRPC rm command to the gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: Iaf1ed08d155cbad11c7aa2b74a9535f4b32233ca
Reviewed-on: https://go-review.googlesource.com/c/build/+/405515
Reviewed-by: Heschi Kreinick <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Alex Rakoczy <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/406857 mentions this issue: cmd/gomote: implements GRPC gettar command

gopherbot pushed a commit to golang/build that referenced this issue May 17, 2022
@cagedmantis
cmd/gomote: implements GRPC gettar command
92f7ca4 
This change adds the implementation for the GRPC gettar comamnd to the
gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: I8b8f12a3104977128d912ced41215faed69ea719
Reviewed-on: https://go-review.googlesource.com/c/build/+/406857
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Carlos Amedee <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue May 19, 2022
@cagedmantis
cmd/gomote: implements GRPC put command
7c4023b 
This change adds the implementation for GRPC put command to the gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: Ib2376444321ef9d0a754b60bcd3783f66a932f3d
Reviewed-on: https://go-review.googlesource.com/c/build/+/406015
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Heschi Kreinick <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/407878 mentions this issue: cmd/gomote: implements GRPC puttar command

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/410818 mentions this issue: internal/gomote,cmd/gomote: implements GRPC add bootstrap

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/410819 mentions this issue: cmd/gomote: implements GRPC push command

@cagedmantis
Copy link
Contributor Author

CLs are in. Closing.

gopherbot pushed a commit to golang/build that referenced this issue Jun 7, 2022
@cagedmantis @gopherbot
cmd/gomote: implements GRPC puttar command
d6944ca 
This change adds the implementation for GRPC puttar command to the
gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: I9b500b2f3ca70c78c3f288d0280eba02a1c59554
Reviewed-on: https://go-review.googlesource.com/c/build/+/407878
Auto-Submit: Carlos Amedee <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Run-TryBot: Carlos Amedee <[email protected]>
Reviewed-by: Alex Rakoczy <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Jun 7, 2022
@cagedmantis @gopherbot
internal/gomote,cmd/gomote: implements GRPC add bootstrap
8e08734 
This change adds the implementation for GRPC putbootstrap command to the
gomote client. It also adds the gomote server implementation of the
AddBootstrap endpoint. This endpoint adds the bootstrap Go version to
an existing client.

Updates golang/go#48737
Updates golang/go#48742
For golang/go#47521

Change-Id: Ib0807a13e85a0e350485c8300ac2e180456bd0fc
Reviewed-on: https://go-review.googlesource.com/c/build/+/410818
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Carlos Amedee <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
Reviewed-by: Alex Rakoczy <[email protected]>
gopherbot pushed a commit to golang/build that referenced this issue Jun 7, 2022
@cagedmantis @gopherbot
cmd/gomote: implements GRPC push command
192ed73 
This change adds the implementation for GRPC push command to the
gomote client.

Updates golang/go#48737
For golang/go#47521

Change-Id: Ibb40dff14b9be0c273fb26a625d5e64b1bca25f0
Reviewed-on: https://go-review.googlesource.com/c/build/+/410819
Reviewed-by: Carlos Amedee <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Run-TryBot: Carlos Amedee <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/412374 mentions this issue: cmd/gomote: adds missing field to GRPC push

gopherbot pushed a commit to golang/build that referenced this issue Jun 15, 2022
@cagedmantis
cmd/gomote: add missing field to GRPC push
f7e019d 
This change adds a missing directory setting to the GRPC push command.

For golang/go#48737
For golang/go#47521

Change-Id: I33daab7da55403df83033d0d4b6921bfeb10623c
Reviewed-on: https://go-review.googlesource.com/c/build/+/412374
Reviewed-by: Dmitri Shuralyov <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
Auto-Submit: Carlos Amedee <[email protected]>
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Archived in project
Milestone
Backlog
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot