Skip to content

x/exp/winfsnotify: delete package #51447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcmills opened this issue Mar 3, 2022 · 7 comments
Closed

x/exp/winfsnotify: delete package #51447

bcmills opened this issue Mar 3, 2022 · 7 comments

Comments

@bcmills
Copy link
Contributor

bcmills commented Mar 3, 2022

The x/exp/winfsnotify package was moved from the standard library to the x/exp repository in CL 7456047, a little over nine years ago. It has apparently not been touched since then except to add an // import comment in 2014. In 2016, users discussed switching to an externally-maintained alternative (see @nathany's comment in #17244 (comment)).

At least one such alternative, github.com/fsnotify/fsnotify, was still actively maintained at least as of this January (see fsnotify/fsnotify#413), and has a number of volunteers to maintain it going forward.

In the meantime x/exp/winfsnotify has rotted. It has no active owners and its only substantial test is flaky (#49734). The corresponding fsnotify package for Unix platforms was removed in CL 3990, back in 2015.

The packages in the x/exp repository are explicitly experimental. I propose that we declare the x/exp/winfsnotify experiment concluded and delete the package.

@gopherbot gopherbot added this to the Proposal milestone Mar 3, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/389615 mentions this issue: winfsnotify: delete package

@rsc
Copy link
Contributor

rsc commented Mar 16, 2022

Given the overwhelming evidence, I think we can make this a direct accept.

@rsc
Copy link
Contributor

rsc commented Mar 16, 2022

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: x/exp/winfsnotify: delete package x/exp/winfsnotify: delete package Mar 16, 2022
@rsc rsc modified the milestones: Proposal, Backlog Mar 16, 2022
@rsc
Copy link
Contributor

rsc commented Mar 16, 2022

@bcmills one think we should consider is checking in a go.mod in that directory first, before the delete, so that if anyone really does need it, they can use it as a separate submodule even if they also need a newer x/exp for other reasons.

@bcmills
Copy link
Contributor Author

bcmills commented Mar 16, 2022

That seems reasonable. Probably we should also add a deprecation notice to the tombstone version, and tag it something like winfsnotify/v0.1.0-deprecated so that it can be resolved from the version list.

@bcmills bcmills self-assigned this Mar 16, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/399834 mentions this issue: winfsnotify: deprecate package and isolate it to its own module

@bcmills
Copy link
Contributor Author

bcmills commented Jun 2, 2022

This is done: the winfsnotify package no longer exists at HEAD, but remains available in module golang.org/x/exp/winfsnotify at its terminal version v0.1.0-deprecated.

I've also confirmed that the documentation for the final, deprecated version is correctly shown at https://pkg.go.dev/golang.org/x/exp/winfsnotify.

@rsc rsc unassigned bcmills Jun 22, 2022
@rsc rsc moved this to Accepted in Proposals Aug 10, 2022
@rsc rsc added this to Proposals Aug 10, 2022
@rsc rsc removed this from Proposals Jun 7, 2023
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants