Skip to content

all: move dev.boringcrypto into main branch behind GOEXPERIMENT #51940

Closed
@rsc

Description

@rsc

The dev.boringcrypto branch started out as a bit of an experiment, back in the Go 1.8 time frame. It is clearly here to stay as something that we maintain alongside the main distribution.

Maintaining a whole separate branch is cumbersome, requiring frequent conflict resolution during merges and being just generally painful.

It would be far less upkeep if we kept the boringcrypto code in the main branch behind a GOEXPERIMENT, same as we do for GOEXPERIMENT=fieldtrack. We should do that.

This bug is to track work toward that goal. Generally speaking it will require a little bit of rewriting of parts that we can't reasonably merge and then a bunch of build tags.

Activity

added
NeedsFixThe path to resolution is known, but the work has not been done.
on Mar 25, 2022
added this to the Go1.19 milestone on Mar 25, 2022
self-assigned this
on Mar 25, 2022
gopherbot

gopherbot commented on Mar 25, 2022

@gopherbot
Contributor

Change https://go.dev/cl/395815 mentions this issue: dashboard: add linux-amd64-boringcrypto builder

gopherbot

gopherbot commented on Mar 25, 2022

@gopherbot
Contributor

Change https://go.dev/cl/395881 mentions this issue: [dev.boringcrypto] all: add boringcrypto build tags

gopherbot

gopherbot commented on Mar 25, 2022

@gopherbot
Contributor

Change https://go.dev/cl/395879 mentions this issue: [dev.boringcrypto] make.bash: disable GOEXPERIMENT when using bootstrap toolchain

gopherbot

gopherbot commented on Mar 25, 2022

@gopherbot
Contributor

Change https://go.dev/cl/395880 mentions this issue: [dev.boringcrypto] internal/goexperiment: add GOEXPERIMENT=boringcrypto

gopherbot

gopherbot commented on Mar 25, 2022

@gopherbot
Contributor

Change https://go.dev/cl/395883 mentions this issue: [dev.boringcrypto] crypto/ecdsa, crypto/rsa: use boring.Cache

gopherbot

gopherbot commented on Mar 25, 2022

@gopherbot
Contributor

Change https://go.dev/cl/395884 mentions this issue: [dev.boringcrypto] cmd/compile: remove the awful boringcrypto kludge

gopherbot

gopherbot commented on Mar 25, 2022

@gopherbot
Contributor

Change https://go.dev/cl/395876 mentions this issue: [dev.boringcrypto] crypto/internal/boring: make SHA calls allocation-free

gopherbot

gopherbot commented on Mar 25, 2022

@gopherbot
Contributor

Change https://go.dev/cl/395878 mentions this issue: [dev.boringcrypto] crypto/x509: rename VerifyOptions.IsBoring to AllowCert

gopherbot

gopherbot commented on Mar 25, 2022

@gopherbot
Contributor

Change https://go.dev/cl/395882 mentions this issue: [dev.boringcrypto] crypto/internal/boring: add GC-aware cache

gopherbot

gopherbot commented on Mar 25, 2022

@gopherbot
Contributor

Change https://go.dev/cl/395877 mentions this issue: [dev.boringcrypto] crypto/..., go/build: align deps test with standard rules

qmuntal

qmuntal commented on Mar 28, 2022

@qmuntal
Member

@rsc have you considered moving crypto/internal/boring to golang.org/x/crypto/boring and use it as a vendored package? This approach is showing good results in our out-of-tree OpenSSL port, reducing code bloat in the main repo and making it easier to maintain and backport.

56 remaining items

added a commit that references this issue on Mar 3, 2023
added a commit that references this issue on Mar 3, 2023
linouk23

linouk23 commented on Mar 4, 2023

@linouk23
added a commit that references this issue on Mar 6, 2023
added a commit that references this issue on Mar 7, 2023
added a commit that references this issue on Mar 15, 2023
locked and limited conversation to collaborators on Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

Type

No type

Projects

Status

Done

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @srikanthps@rsc@liggitt@ianlancetaylor@qmuntal

      Issue actions

        all: move dev.boringcrypto into main branch behind GOEXPERIMENT · Issue #51940 · golang/go